Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abstract method execute() to \Magento\Framework\App\Action\Action #1416

Merged
merged 1 commit into from
Jul 17, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
*/
namespace Magento\AdminNotification\Controller\Adminhtml;

class Notification extends \Magento\Backend\App\AbstractAction
abstract class Notification extends \Magento\Backend\App\AbstractAction
{
/**
* @return bool
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Backend/App/Action.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@
/**
* @SuppressWarnings(PHPMD.NumberOfChildren)
*/
class Action extends \Magento\Backend\App\AbstractAction
abstract class Action extends \Magento\Backend\App\AbstractAction
{
}
2 changes: 1 addition & 1 deletion app/code/Magento/Backend/Controller/Adminhtml/Auth.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
/**
* Auth backend controller
*/
class Auth extends AbstractAction
abstract class Auth extends AbstractAction
{
/**
* Check if user has permissions to access this controller
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Backend/Controller/Adminhtml/Cache.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
use Magento\Backend\App\Action;
use Magento\Framework\Exception\LocalizedException;

class Cache extends Action
abstract class Cache extends Action
{
/**
* @var \Magento\Framework\App\Cache\TypeListInterface
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
*/
namespace Magento\Backend\Controller\Adminhtml;

class Dashboard extends \Magento\Backend\App\Action
abstract class Dashboard extends \Magento\Backend\App\Action
{
/**
* @return bool
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Backend/Controller/Adminhtml/Index.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
/**
* Index backend controller
*/
class Index extends AbstractAction
abstract class Index extends AbstractAction
{
/**
* Check if user has permissions to access this controller
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Backend/Controller/Adminhtml/System.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
*
* @author Magento Core Team <core@magentocommerce.com>
*/
class System extends AbstractAction
abstract class System extends AbstractAction
{
/**
* @return bool
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
*
* @author Magento Core Team <core@magentocommerce.com>
*/
class Account extends Action
abstract class Account extends Action
{
/**
* @return bool
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

use Magento\Backend\App\Action;

class Design extends Action
abstract class Design extends Action
{
/**
* Core registry
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
*
* @author Magento Core Team <core@magentocommerce.com>
*/
class Store extends Action
abstract class Store extends Action
{
/**
* Core registry
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Backup/Controller/Adminhtml/Index.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
*
* @author Magento Core Team <core@magentocommerce.com>
*/
class Index extends \Magento\Backend\App\Action
abstract class Index extends \Magento\Backend\App\Action
{
/**
* Core registry
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Catalog/Controller/Adminhtml/Category.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
/**
* Catalog category controller
*/
class Category extends \Magento\Backend\App\Action
abstract class Category extends \Magento\Backend\App\Action
{
/**
* Initialize requested category and put it into registry.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
*
* @author Magento Core Team <core@magentocommerce.com>
*/
class Widget extends \Magento\Backend\App\Action
abstract class Widget extends \Magento\Backend\App\Action
{
/**
* @var \Magento\Framework\View\LayoutFactory
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Catalog/Controller/Adminhtml/Product.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
* Catalog product controller
* @SuppressWarnings(PHPMD.NumberOfChildren)
*/
class Product extends \Magento\Backend\App\Action
abstract class Product extends \Magento\Backend\App\Action
{
/**
* @var Product\Builder
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
use Magento\Catalog\Controller\Adminhtml\Product;
use Magento\Framework\Controller\Result;

class AbstractProductGrid extends Product
abstract class AbstractProductGrid extends Product
{
/**
* @var \Magento\Framework\View\Result\LayoutFactory
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
/**
* Adminhtml catalog product action attribute update controller
*/
class Attribute extends Action
abstract class Attribute extends Action
{
/**
* @var \Magento\Catalog\Helper\Product\Edit\Action\Attribute
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
use Magento\Framework\Controller\Result;
use Magento\Framework\View\Result\PageFactory;

class Attribute extends \Magento\Backend\App\Action
abstract class Attribute extends \Magento\Backend\App\Action
{
/**
* @var \Magento\Framework\Cache\FrontendInterface
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
*
* @author Magento Core Team <core@magentocommerce.com>
*/
class Set extends \Magento\Backend\App\Action
abstract class Set extends \Magento\Backend\App\Action
{
/**
* Core registry
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Catalog/Controller/Product.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
use Magento\Catalog\Controller\Product\View\ViewInterface;
use Magento\Catalog\Model\Product as ModelProduct;

class Product extends \Magento\Framework\App\Action\Action implements ViewInterface
abstract class Product extends \Magento\Framework\App\Action\Action implements ViewInterface
{
/**
* Initialize requested product object
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Catalog/Controller/Product/Compare.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* @SuppressWarnings(PHPMD.LongVariable)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class Compare extends \Magento\Framework\App\Action\Action
abstract class Compare extends \Magento\Framework\App\Action\Action
{
/**
* Customer id
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
use Magento\Framework\Registry;
use Magento\Framework\Stdlib\DateTime\Filter\Date;

class Catalog extends Action
abstract class Catalog extends Action
{
/**
* Dirty rules notice message
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

use Magento\Backend\App\Action;

class Widget extends Action
abstract class Widget extends Action
{
/**
* @return bool
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
/**
* Class Widget
*/
class Widget extends Action
abstract class Widget extends Action
{
/**
* @return bool
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Checkout/Controller/Cart.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
/**
* Shopping cart controller
*/
class Cart extends \Magento\Framework\App\Action\Action implements ViewInterface
abstract class Cart extends \Magento\Framework\App\Action\Action implements ViewInterface
{
/**
* @var \Magento\Framework\App\Config\ScopeConfigInterface
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Checkout/Controller/Onepage.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
/**
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class Onepage extends Action
abstract class Onepage extends Action
{
/**
* @var array
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ protected function setUp()
$context->expects($this->once())
->method('getEventManager')
->willReturn($this->eventManager);

$this->controller = $objectManager->getObject(
'Magento\Checkout\Controller\Onepage',
'Magento\Checkout\Test\Unit\Controller\Stub\OnepageStub',
[
'context' => $context
]
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<?php


namespace Magento\Checkout\Test\Unit\Controller\Stub;

class OnepageStub extends \Magento\Checkout\Controller\Onepage
{
protected function execute()
{
// Empty method stub for test
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*/
namespace Magento\CheckoutAgreements\Controller\Adminhtml;

class Agreement extends \Magento\Backend\App\Action
abstract class Agreement extends \Magento\Backend\App\Action
{
/**
* Core registry
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Cms/Controller/Adminhtml/Block.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
*
* @author Magento Core Team <core@magentocommerce.com>
*/
class Block extends \Magento\Backend\App\Action
abstract class Block extends \Magento\Backend\App\Action
{
/**
* Core registry
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
*
* @author Magento Core Team <core@magentocommerce.com>
*/
class Images extends \Magento\Backend\App\Action
abstract class Images extends \Magento\Backend\App\Action
{
/**
* Core registry
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Contact/Controller/Index.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
/**
* Contact index controller
*/
class Index extends \Magento\Framework\App\Action\Action
abstract class Index extends \Magento\Framework\App\Action\Action
{
/**
* Recipient email config path
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public function setUp()
)
);

$this->_controller = new \Magento\Contact\Controller\Index(
$this->_controller = new \Magento\Contact\Test\Unit\Controller\Stub\IndexStub(
$context,
$this->getMock('\Magento\Framework\Mail\Template\TransportBuilder', [], [], '', false),
$this->getMockForAbstractClass('\Magento\Framework\Translate\Inline\StateInterface', [], '', false),
Expand Down
12 changes: 12 additions & 0 deletions app/code/Magento/Contact/Test/Unit/Controller/Stub/IndexStub.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<?php


namespace Magento\Contact\Test\Unit\Controller\Stub;

class IndexStub extends \Magento\Contact\Controller\Index
{
protected function execute()
{
// Empty method stub for test
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
*/
namespace Magento\CurrencySymbol\Controller\Adminhtml\System;

class Currency extends \Magento\Backend\App\Action
abstract class Currency extends \Magento\Backend\App\Action
{
/**
* Core registry
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
*/
namespace Magento\CurrencySymbol\Controller\Adminhtml\System;

class Currencysymbol extends \Magento\Backend\App\Action
abstract class Currencysymbol extends \Magento\Backend\App\Action
{
/**
* Check the permission to run it
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Customer/Controller/Account.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
* @SuppressWarnings(PHPMD.NumberOfChildren)
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class Account extends \Magento\Framework\App\Action\Action
abstract class Account extends \Magento\Framework\App\Action\Action
{
/**
* List of actions that are allowed for not authorized users
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Customer/Controller/Address.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
*
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class Address extends \Magento\Framework\App\Action\Action
abstract class Address extends \Magento\Framework\App\Action\Action
{
/**
* @var \Magento\Customer\Model\Session
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
*
* @author Magento Core Team <core@magentocommerce.com>
*/
class Cart extends \Magento\Backend\App\Action
abstract class Cart extends \Magento\Backend\App\Action
{
/**
* Customer we're working with
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Customer/Controller/Adminhtml/Group.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
/**
* Customer groups controller
*/
class Group extends \Magento\Backend\App\Action
abstract class Group extends \Magento\Backend\App\Action
{
/**
* Core registry
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Customer/Controller/Adminhtml/Index.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
* @SuppressWarnings(PHPMD.TooManyFields)
* @SuppressWarnings(PHPMD.NumberOfChildren)
*/
class Index extends \Magento\Backend\App\Action
abstract class Index extends \Magento\Backend\App\Action
{
/**
* @var \Magento\Framework\Validator
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
*
* @author Magento Core Team <core@magentocommerce.com>
*/
class Validatevat extends \Magento\Backend\App\Action
abstract class Validatevat extends \Magento\Backend\App\Action
{
/**
* Perform customer VAT ID validation
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
/**
* Catalog composite product configuration controller
*/
class Wishlist extends \Magento\Backend\App\Action
abstract class Wishlist extends \Magento\Backend\App\Action
{
/**
* Wishlist we're working with.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
*
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*/
class Editor extends \Magento\Backend\App\Action
abstract class Editor extends \Magento\Backend\App\Action
{
/**
* @var \Magento\Theme\Model\Config
Expand Down
Loading