[Backport to 2.1-develop] Fix configurable attribute options not being sorted #12962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See github issue magento#7441, internal ticket MAGETWO-61484 and PR magento#12420.
magento-engcom-team
added
bugfix
Component: Catalog
Reproduced on 2.1.x
|
I noticed the PHP code sniffer failure and will address it one of the next coming days. |
Corrected multi-line indents based on the report by the PHP static tests. See build reports for PR magento#12962
|
Hello @ishakhsuvarov, thank you for your feedback. You might have found it by now, but a similar pull request for 2.2-develop (holding the very same changes) was set up as well, see PR #12963 for the Magento 2.2.x version of the fix. Apart from that, the PHP code sniffer errors are now corrected (within this PR). |
|
@wardcapp Sorry, concentrated on the one linked in the description too much :) |
magento-team
pushed a commit
that referenced
this pull request
Jan 10, 2018
…ptions not being sorted #12962
magento-engcom-team
added
Fixed in 2.1.x
|
Hi, I noticed changes are already in 2.1.13 version but changes are not visible, my attributes are always unsorted. Damien. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See github issue #7441, internal ticket MAGETWO-61484 and PR #12420.
Description
Resolves the issue documented in GitHub ticket #7441. A similar PR was opened before (#12420), which was now ported to Magento 2.1.x and required changes to the related unit tests were made as well.
Fixed Issues
Manual testing scenarios
(copied over from PR #12420, which is still valid)
Steps to reproduce
Create a configurable attribute and add two options at least.
Create a configurable product for these options.
Go to the product page and see the configurable attribute select (options).
Change attribute options sort order and flush all caches.
Go to the product page and see the configurable attribute select (options) looks like before.
Expected result:
Configurable options HAVE been reordered.
Contribution checklist