Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix another typo #12687

Closed
wants to merge 1 commit into from
Closed

Fix another typo #12687

wants to merge 1 commit into from

Conversation

PieterCappelle
Copy link
Contributor

Very small typo, sorry for 2 PR's

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@sidolov sidolov self-assigned this Dec 14, 2017
@sidolov sidolov added this to the December 2017 milestone Dec 14, 2017
@sidolov
Copy link
Contributor

sidolov commented Dec 14, 2017

Hi @PieterCappelle , it's not a typo, test \Magento\ImportExport\Controller\Adminhtml\Import\ValidateTest::testValidationReturn expects that in csv will be incorrect data for attribute 'visibility'. Dataset for this test introduced in the scope of #11732 and covers manual scenarios described in the PR.

@sidolov sidolov closed this Dec 14, 2017
@PieterCappelle
Copy link
Contributor Author

Sorry! Was using it for sample import and didn't think about it :)

@PieterCappelle PieterCappelle deleted the patch-3 branch December 14, 2017 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sidolov sidolov

Labels
Release Line: 2.2
Projects
None yet
Milestone
December 2017
Development

Successfully merging this pull request may close these issues.
2 participants
@PieterCappelle @sidolov