Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.3] Added namespace to product videos fotorama events #12556

Merged
merged 2 commits into from
Dec 11, 2017
Merged

[Backport 2.3] Added namespace to product videos fotorama events #12556

merged 2 commits into from
Dec 11, 2017

Conversation

roma84
Copy link
Contributor

@roma84 roma84 commented Dec 6, 2017

Description

This pull request fixes issue with ignored gallery config in view.xml on configurable products.
It happens because clearEvents function removes all fotorama event listeners.
I added event namespace to only remove product videos related events.
Please check #12268 for more details.

Fixed Issues (if relevant)

  1. Gallery issues on configurable product page #12268: Gallery issues on configurable product page

Manual testing scenarios

  1. Open app/design/frontend/Magento/luma/etc/view.xml and change navdir to vertical on line 216.
  2. Open configurable product and select size and color.
  3. Click on the image to open full screen view.

Backport

#12469 Added namespace to product videos fotorama events

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@omiroshnichenko omiroshnichenko added this to the December 2017 milestone Dec 6, 2017
@omiroshnichenko omiroshnichenko added Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line labels Dec 8, 2017
@magento-team magento-team merged commit b4d089b into magento:2.3-develop Dec 11, 2017
magento-team pushed a commit that referenced this pull request Dec 11, 2017
@ishakhsuvarov
MAGETWO-85096: [Backport 2.3] Added namespace to product videos fotor…
ae741ad 
…ama events #12556
magento-team pushed a commit that referenced this pull request Dec 11, 2017
@ishakhsuvarov
Merge pull request #1818 from magento-engcom/develop-prs
a6f3e1d 
[EngCom] Public Pull Requests - develop
 - MAGETWO-85225: [2.3] - Add schedule backlog to indexer:status #12592
 - MAGETWO-85096: [Backport 2.3] Added namespace to product videos fotorama events #12556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@omiroshnichenko omiroshnichenko

Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Progress: accept Release Line: 2.3
Projects
None yet
Milestone
December 2017
Development

Successfully merging this pull request may close these issues.
3 participants
@roma84 @magento-team @omiroshnichenko