Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#10765 Export data from grid not adding custom rendered data magento2 #12373

Merged
merged 2 commits into from
Nov 24, 2017
Merged

#10765 Export data from grid not adding custom rendered data magento2 #12373

merged 2 commits into from
Nov 24, 2017

Conversation

Zefiryn
Copy link
Contributor

@Zefiryn Zefiryn commented Nov 21, 2017

Description

Adding methods to set text values for data pulled from customer_grid_flat table during CSV export

Fixed Issues (if relevant)

#10765

Manual testing scenarios

  1. login to admin panel.
  2. Go to customer panel, and click on export button to export details in CSV format.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@hatimeria-artur-jewula @Zefiryn
# This is a combination of 3 commits.
5f3ef1b 
# This is the 1st commit message:
magento#10765 add confirmation and lock_expires labels to customer grid CSV export

# This is the commit message magento#2:

magento#10765 Add tests for added methods

# This is the commit message magento#3:

10765 code refactoring
@hatimeria-artur-jewula @Zefiryn
magento#10765 add confirmation and lock_expires labels to customer g…
74e1d85 
…rid CSV export
@magento-engcom-team magento-engcom-team added bugfix Fixed in 2.2.x The issue has been fixed in 2.2 release line ready for backport labels Nov 21, 2017
@dmanners
Copy link
Contributor

Relates to #12375

@dmanners dmanners mentioned this pull request Nov 21, 2017
Merged
4 tasks
@ishakhsuvarov ishakhsuvarov self-assigned this Nov 21, 2017
@ishakhsuvarov ishakhsuvarov added this to the November 2017 milestone Nov 21, 2017
@magento-team magento-team merged commit 74e1d85 into magento:2.1-develop Nov 24, 2017
magento-team pushed a commit that referenced this pull request Nov 24, 2017
@ishakhsuvarov
MAGETWO-84238: #10765 Export data from grid not adding custom rendere…
9327ed5 
…d data magento2 #12373
magento-team pushed a commit that referenced this pull request Nov 24, 2017
@ishakhsuvarov
Merge pull request #1760 from magento-engcom/2.1-develop-prs
3a3119d 
[EngCom] Public Pull Requests - 2.1-develop
 - MAGETWO-84238: #10765 Export data from grid not adding custom rendered data magento2 #12373
 - MAGETWO-83282: Backport 2.1-develop] Fix datetime type product that show current date when is empty in grids #12033
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
bugfix Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.1
Projects
None yet
Milestone
November 2017
Development

Successfully merging this pull request may close these issues.
6 participants
@Zefiryn @dmanners @magento-team @ishakhsuvarov @magento-engcom-team @hatimeria-artur-jewula