Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.2] Close PayPal popup window in case of rejected request #10820 #12131

Conversation

vovayatsyuk
Copy link
Member

Original PR: #10820
It's merged in 2.3 together with some other changes: 53072e0

Description

PayPal express pop-up stays opened when the 'setPaymentMethodAction' request was rejected.

Manual testing scenarios

  1. Trigger an error on the server side for the set-payment-information action
  2. Place an order using PayPal Express in-context mode.
  3. Popup will stay opened and the whole screen dimmed.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@miguelbalparda
Copy link
Contributor

This is going to be merged soon. Thanks for the backport and for your contribution!

@okorshenko okorshenko merged commit f19fa30 into magento:2.2-develop Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants