Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interaction to admin:user:create command #11510

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Add interaction to admin:user:create command #11510

merged 1 commit into from
Oct 24, 2017

Conversation

cmuench
Copy link
Contributor

@cmuench cmuench commented Oct 17, 2017

Description

Add interaction to "admin:user:create" command. This is more convenient and user friendly.
The interaction is done by Symfony Question helper. This is a default class of the Symfony Console component.
If a required option is not passed, the command will ask for the input value. The password is validated against the standard user password validator.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@cmuench
Copy link
Contributor Author

cmuench commented Oct 20, 2017

@vkublytskyi I'm not sure why the integration test failed. It got a timeout. Maybe a travis problem?

@vkublytskyi
Copy link

@cmuench I restarted the job. Issue with Travis failures by timeout should e fixed in #11555.

@davidalger
Copy link
Member

I restarted that job twice already…seems the 3rd time is a charm apparently :)

Very nice work @cmuench!

@cmuench
Copy link
Contributor Author

cmuench commented Oct 20, 2017

Thanks.

@okorshenko okorshenko merged commit 10b57f4 into magento:2.2-develop Oct 24, 2017
@cmuench cmuench deleted the interactive-admin-user-create-command branch October 24, 2017 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants