Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close #10810 Migrates Apache Access Syntax to 2.4 on Apache >= 2.4 #11459

Merged
merged 2 commits into from
Nov 10, 2017
Merged

close #10810 Migrates Apache Access Syntax to 2.4 on Apache >= 2.4 #11459

merged 2 commits into from
Nov 10, 2017

Conversation

jonashrem
Copy link
Contributor

Migrates Apache Access Syntax to 2.4 on Apache >= 2.4

Description

In all .htaccess Files, the Apache 2.2 Auth Blocks like


            order allow,deny
            deny from all

have been replaced with this block:

        <IfVersion < 2.4>
            order allow,deny
            deny from all
        </IfVersion>
        <IfVersion >= 2.4>
            Require all denied
        </IfVersion>

Fixed Issues (if relevant)

  1. Add support of apache2.4 commands in htaccess  #10810: Add support of apache2.4 commands in htaccess

Manual testing scenarios

  1. Install on Apache 2.4 and check whether all file access rules work as intended
  2. Install on Apache 2.2 and check whether all file access rules work as intended

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@jonashrem
close #10810
64943cd 
Migrates Apache Access Syntax to 2.4 on Apaxhe >= 2.4
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 14, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jonashrem jonashrem mentioned this pull request Oct 15, 2017
Merged
4 tasks
@ishakhsuvarov ishakhsuvarov self-assigned this Oct 19, 2017
@ishakhsuvarov ishakhsuvarov added this to the October 2017 milestone Oct 19, 2017
@ishakhsuvarov ishakhsuvarov added Release Line: 2.2 2.2.x Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 19, 2017
@okorshenko okorshenko modified the milestones: October 2017, November 2017 Nov 1, 2017
@okorshenko okorshenko merged commit 00937b1 into magento:2.2-develop Nov 10, 2017
okorshenko pushed a commit that referenced this pull request Nov 10, 2017
MAGETWO-82292: close #10810 Migrates Apache Access Syntax to 2.4 on A…
123dd85 
…pache >= 2.4 #11459
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 10, 2017
okorshenko pushed a commit that referenced this pull request Nov 12, 2017
@ishakhsuvarov
MAGETWO-82294: migrated pull request #11459 to 2.3 develop #11466
d32b8a4 
 - Merge Pull Request #11466 from jonashrem/magento2:10810-2.3
 - Merged commits:
   1. a6f517d
okorshenko pushed a commit that referenced this pull request Nov 12, 2017
MAGETWO-82294: migrated pull request #11459 to 2.3 develop #11466
9628956
okorshenko pushed a commit that referenced this pull request Nov 12, 2017
Merge pull request #1706 from magento-engcom/develop-prs
cf4be3d 
Public Pull Requests

#12155 update button.phtml overcomplicated translation phrase. Magento 2.3 by @ChuckyK
#11680 #8022: Uncaught Error: Call to a member function addItem() on array in app/code/Magento/Sales/Model/Order/Shipment.php by @RomaKis
#11466 migrated pull request #11459 to 2.3 develop by @jonashrem

Fixed Public Issues

#8022 Uncaught Error: Call to a member function addItem() on array in app/code/Magento/Sales/Model/Order/Shipment.php
#10810 Add support of apache2.4 commands in htaccess
@jonashrem
Copy link
Contributor Author

jonashrem commented Aug 9, 2018 •
edited
Loading

@ atefBB

what's wrong with it? The vendor folder has been there before. So I don't see any reason to exclude it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
November 2017
Development

Successfully merging this pull request may close these issues.
6 participants
@jonashrem @magento-cicd2 @atefBB @ishakhsuvarov @okorshenko @magento-engcom-team