Fix #9243 - Upgrade ZF components. Zend_Service #11291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed Magento\Framework\Locale\CurrencyInterface from setService method and changed it to \Zend_Currency_CurrencyInterface which must be provider to this function. - Changed return type to \Zend_Currency_CurrencyInterface, the given instance of the service is returned by the setService function - Removed \Zend_Service from getService method and changed it to \Zend_Currency_CurrencyInterface - Added @deprecated tags to both methods and added @see annotation to the methods. Referenced corresponding interface \Magento\Directory\Model\Currency\Import\ImportInterface
dverkade
changed the title
dverkade
changed the title
magento-team
pushed a commit
that referenced
this pull request
Oct 11, 2017
This was referenced Jan 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issue #9243: