Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual Theme load: Check for null to actually reach the code that handles this case to t… #11240

Merged
merged 2 commits into from
Oct 16, 2017

Conversation

leptoquark1
Copy link

@leptoquark1 leptoquark1 commented Oct 5, 2017

Virtual Theme load: Check for null to actually reach the code that handles this case to throw the appropriate exception

Description

Actually gives the chances for a meaningful Exception when a virtual theme does not a have a physical parent theme. In the previous code this exception was not reachable, since getParentTheme returned null and in the loop it was expected to be a Model/Theme object.

Fixed Issues (if relevant)

  • No Issues fixed

Manual testing scenarios

  1. Create a virtual theme without a physical parent

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 5, 2017

CLA assistant check
All committers have signed the CLA.

@okorshenko okorshenko self-assigned this Oct 16, 2017
@okorshenko okorshenko added this to the October 2017 milestone Oct 16, 2017
@okorshenko okorshenko merged commit 86032de into magento:2.2-develop Oct 16, 2017
okorshenko pushed a commit that referenced this pull request Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants