Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CWE-476-1 #7776

Closed
AppChecker opened this issue Dec 13, 2016 · 3 comments
Closed

CWE-476-1 #7776

AppChecker opened this issue Dec 13, 2016 · 3 comments
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@AppChecker
Copy link

We've checked source code of Magento 2.1.2 and found weakness in it. We haven't checked the work of the programm, we scanned only the source code. So we can't write instructions how tp reproduce the problem because it is not reproducable, it's just a weakness in code that should be fixed. Maybe this part of code is never executed but the weekness is the weekness.

in file:
app/code/Magento/Usps/Model/Carrier.php

        if ($response === false || $response->getName() == 'Error') {
            $debugData['result'] = [
                'error' => $response->Description,
                'code' => $response->Number,
                'xml' => $response->asXML(),
            ];
...
        }

if $response is false, method asXML will be called on false

related to #6715

@vzabaznov
Copy link
Contributor

vzabaznov commented Dec 13, 2016

internal ticket created MAGETWO-62187

@vzabaznov vzabaznov added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Dec 13, 2016
@vzabaznov
Copy link
Contributor

@AppChecker please do not create more related issue, i've created internal issue that contains all your info from #6715 , thanks)

@vzabaznov
Copy link
Contributor

@AppChecker will be fixed in #6715, close for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

2 participants