PageCache gives error "Uncaught TypeError: element.prop is not a function" when there is an iframe

[PascalBrouwers]

Preconditions

1. Magento 2.1.0
2. PHP 7.0.11

Steps to reproduce

1. Install Magento 2.1.0 with module Livechat from https://github.com/livechat/magento-livechat
2. Enable module Livechat: bin/magent module:enable LiveChat_LiveChat
3. Clear cache: bin/magento c:f
4. Go to homepage

Expected result

1. No JavaScript error

Actual result

1. JavaScript error: Uncaught TypeError: element.prop is not a function
   

[PascalBrouwers]

The fix is actually pretty easy.

Change line 40 of page-cache.js
.prop('href', element.prop('src'))
To:
.prop('href', $(element).prop('src'))

But I see it is already fixed 2.1.1

[devhn]

@PascalBrouwers thanks, we applied this fix also within the page-cache.js

[Tristan-N]

@devhn @PascalBrouwers
How come the original file is not fixed yet? I fixed this, last monday I updated to Magento 2.1.3 (from 2.1.2) and now have to apply this fix again.
I use composer to update, so it can be found in the vendor folder.

[PascalBrouwers]

@Tristan-N I was surprised that my 2.1.2 also still has this issue, didn't check 2.1.3 yet.

[Tristan-N]

@PascalBrouwers I did too, but didn't pay any attention and just fixed it again, until the update to 2.1.3. It's that simple, so I was a bit surprised too.

[PascalBrouwers]

The weirdest thing is: they did fix it in the develop branch: https://github.com/magento/magento2/blob/develop/app/code/Magento/PageCache/view/frontend/web/js/page-cache.js

[PascalBrouwers]

@veloraven Can you make sure this get's into the next release?
It was missed in this release as you can see: https://github.com/magento/magento2/blob/2.1.3/app/code/Magento/PageCache/view/frontend/web/js/page-cache.js

[erfanimani]

It's still happening on 2.14..

[petterkj]

Also happening in 2.1.5.

Hint for fix? https://mage2.pro/t/topic/999/2