Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable email communication set to yes: email did get sent. #5988

Closed
Tristan-N opened this issue Aug 4, 2016 · 13 comments
Closed

Disable email communication set to yes: email did get sent. #5988

Tristan-N opened this issue Aug 4, 2016 · 13 comments
Labels
bug report Component: Customer Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@Tristan-N
Copy link

Tristan-N commented Aug 4, 2016 •
edited
Loading

After installing a data migration tool I disabled all Email communication for all store-views. However, people who are subscribed to the newsletter received a confirmation e-mail with the basic Luma template without any data (see screenshot). Sender of email turned out to be owner@example.com.

Preconditions

  1. Magento CE 2.1.0
  2. PHP 7.0.9

Steps to reproduce

  1. Installed module for data migration.
  2. Went to Store -> Configuration -> Advanced -> System -> Email Sending Settings
  3. Set Disable Email Communications to Yes.
  4. Checked on all store views if setting was disabled.
  5. Migrated Customers from Magento 1.9.2.4 to Magento 2.1.0.
  6. Received confirmation e-mail for subscription to a newsletter. Mails were sent to subscribers of 1 particular store view.
  7. Search for loggs or mailhistory to see what happend. There are no logs anywhere that tells me any email were sent.

Expected result

  1. After migration no persons should receive any email when the option Disable Email Communication is set to Yes. Email wasn't even configured yet.

Actual result

  1. Owner@example.com sent an email to all customers subscribed to the newsletter of the Magento 1 store, only showing (in Dutch) "You successfully subscribed to our newsletter."
    See screenshot (red marks are because of the store data there).
    newsletter_confirmation_jpg
@drwebbe
Copy link

drwebbe commented Sep 9, 2016

Same here :
Set Disable Email Communications to Yes.
But order confirmation mails are being sent.

@ghost
Copy link

ghost commented Sep 20, 2016

I've checked the magento 2 source. The only module wich seems the be looking a the value of the smtp_disable config is the newsletter module. It uses the isValidForSend method. The rest of the Magento 2 Emails does not use the setting and therefore always sends out emails. Not ideal in development type situations!! Please fix. Thanks

@victor-v-rad
Copy link
Contributor

@Tristan-N
what exactly the tool do you use? Is it official Data Migration Tool from Magento or it is third party extension?

@victor-v-rad victor-v-rad reopened this Sep 23, 2016
@ilol
Copy link

ilol commented Sep 23, 2016

Did you use Magento`s Data Migration Tool ?

@ghost
Copy link

ghost commented Sep 23, 2016

@Tristan-N I've created a email catcher. Wich also makes it possible to disable all email communication https://github.com/experius/Magento-2-Email-Catcher-Module

@Tristan-N
Copy link
Author

Tristan-N commented Sep 26, 2016 •
edited
Loading

@ilol @victor-v-rad I did it once with the Migration tool from Magento and suffered this problem so I reinstalled the entire Magento installation and used LitExtension Cart Migration. With both migration tools the same problem.

@dheesbeen Thanks!

@ilol
Copy link

ilol commented Sep 26, 2016

@victor-v-rad can you please check it?

@sevos1984
Copy link
Contributor

Internal ticket created MAGETWO-59146. Thanks for reporting

@sevos1984 sevos1984 added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Sep 29, 2016
mmansoor-magento pushed a commit that referenced this issue Oct 6, 2016
@slavvka
MAGETWO-59146: [Github] Disable email communication set to yes: email…
34257ca 
… did get sent. #5988
mmansoor-magento pushed a commit that referenced this issue Oct 6, 2016
@slavvka
MAGETWO-59146: [Github] Disable email communication set to yes: email…
5b5fd02 
… did get sent. #5988
mmansoor-magento pushed a commit that referenced this issue Oct 6, 2016
@slavvka
Merge pull request #466 from magento-south/BUGS
4d69ecb 
[South] Bug fixes
- MAGETWO-56529 Magento\Framework\Session\SaveHandlerTest test failed
- MAGETWO-55794 [FT] Product is not assigned to category
- MAGETWO-56370 [GITHUB] Broken File Type Custom Option #5434
- MAGETWO-59146 [Github] Disable email communication set to yes: email did get sent. #5988
- MAGETWO-56871 [GITHUB] Non-admin do not have permission to search for Categories in Cart Price Rules #6168
@slavvka
Copy link
Member

slavvka commented Oct 6, 2016

The issue has been fixed and delivered to mainline

@slavvka slavvka closed this as completed Oct 6, 2016
@Ctucker9233
Copy link

@slavvka Is this fix safe to integrate into a 2.1.1 production environment or is there a patch pending?

@slavvka
Copy link
Member

slavvka commented Oct 11, 2016

Hi @Ctucker9233, I think it is safe to apply the fix for both 2.0 and 2.1. Please see 34257ca and 5b5fd02 commits.

okorshenko pushed a commit that referenced this issue Jul 5, 2017
@svitja
MAGETWO-59173: [Backport] [Github] Disable email communication set to…
8e17f18 
… yes: email did get sent. #5988 - 2.1
okorshenko pushed a commit that referenced this issue Jul 5, 2017
@svitja
MAGETWO-59173: [Backport] [Github] Disable email communication set to…
4e5dcea 
… yes: email did get sent. #5988 - 2.1
okorshenko pushed a commit that referenced this issue Jul 5, 2017
@svitja
MAGETWO-59173: [Backport] [Github] Disable email communication set to…
96e8eb7 
… yes: email did get sent. #5988 - 2.1
okorshenko pushed a commit that referenced this issue Jul 5, 2017
@svitja
MAGETWO-59173: [Backport] [Github] Disable email communication set to…
c7dd3c3 
… yes: email did get sent. #5988 - 2.1
okorshenko pushed a commit that referenced this issue Jul 5, 2017
@svitja
MAGETWO-59173: [Backport] [Github] Disable email communication set to…
942a310 
… yes: email did get sent. #5988 - 2.1
okorshenko pushed a commit that referenced this issue Jul 5, 2017
@MomotenkoNatalia
Merge pull request #1205 from magento-tsg/2.1.8-develop-pr18
3016ddf 
Fixed issues;
- MAGETWO-59173: [Backport] [Github] Disable email communication set to yes: email did get sent. #5988
- MAGETWO-59622: cannot upgrade 2.0 => 2.1 with auto_increment > 1 
- MAGETWO-59775: static content deployment does not generate secure content
- MAGETWO-60723: [Backport] - Nginx doesn't redirect to setup page when using port 
- MAGETWO-61262: [Backport] - CMS Hierarchy menu is not shown when adding a page to hierarchy (when URL rewrite for new page exists) 
- MAGETWO-61267: [Backport] - view/edit scheduled update option for product disappears from product edit page
- MAGETWO-63589: [Backport] - [Github] Imported configurable products with multiple super attributes do not retain super attribute ordering #6079 
- MAGETWO-67751: [FT] UpdateAdminUserEntityTest fails on variation UpdateAdminGwsUserEntityTestVariation100 on EE (HTTPS enabled, Chrome)
- MAGETWO-69474: [FT] CreateProductAttributeEntityFromProductPageTest (CreateProductAttributeEntityFromProductPageTestVariation1_Searchable_Global_Visible_Comparable_HtmlAllowed_UsedForSorting) unstable for 2.1.7 (CE)
@Ctucker9233
Copy link

@magento-engcom-team This is fixed for 2.1x now correct? Has it been released in a particular version?

@hostep
Copy link
Contributor

hostep commented Feb 28, 2018

@Ctucker9233: by quickly looking at the class Magento\Email\Model\Plugin\TransportInterfacePlugin in various versions of 2.1, and I can see the class was introduced in version 2.1.8, and the release notes for 2.1.8 also mention this:

Magento no longer sends email when the Disable email communication setting is set to yes. Previously, Magento sent email even when this setting was enabled. GitHub-5988

So should be fixed in 2.1.x indeed! :)

magento-engcom-team pushed a commit that referenced this issue Aug 12, 2020
@naydav
Merge pull request #5988 from magento-engcom/MC-36526
a360c06 
MC-36526: Revert public PR:27340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report Component: Customer Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@hostep @victor-v-rad @andimov @ilol @slavvka @sevos1984 @drwebbe @Tristan-N @Ctucker9233