Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magento 2.1.0] Translation #5861

Closed
vjacquemin-sqli opened this issue Jul 28, 2016 · 10 comments
Closed

[Magento 2.1.0] Translation #5861

vjacquemin-sqli opened this issue Jul 28, 2016 · 10 comments
Assignees
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@vjacquemin-sqli
Copy link

Dynamic translations does not work in customer registration page (password strength indicator)

@andidhouse
Copy link

It also does not work in some other parts of the checkout as well. Also some codes are used more then once. If you change it on one place it is also changed at another place - for example step 1 checkout title is used at the cart page totals as well which makes no sense at all.

Also: The translation (inline frontend) does not work for the checkout user data? street address/city/zip code etc.

The inline translation seems very buggy at this stage :/

@andimov
Copy link
Contributor

andimov commented Jul 29, 2016

@vjacquemin-sqli
Thank you for reporting!
To allow us to research the issue, please, provide description according to the template.

@andidhouse
Copy link

Magento 2.1 / Nginx / phh7 / varnish / redis

  1. Turn inline translation on for frontend in the backend
  2. Go to registration page in the frontend
  3. Try to edit password strength indicator

Expected Results:

The password strength indicator can be edited

Results:

The password strength indicator can NOT be edited

The translation also does not work as i wrote for some checkout parts. It is kind of not consistent - for some parts it works for some it does not at all.

@vjacquemin-sqli
Copy link
Author

Magento 2.1 / Apache / phh7 / varnish

Write password in customer registration
Expected Results:

error message is not translated

Results:

Error message is not translated

Same as andidhouse. Some error message translation work and for some, it does not work.

@pboisvert
Copy link

@antboiko not sure why this was labeled as "prod" but passing to you since you own translations

@andimov
Copy link
Contributor

andimov commented Aug 8, 2016

@antboiko Sorry if this was incorrect. Should we implement the translations of these messages?

@andimov andimov removed the PROD label Aug 8, 2016
@antboiko
Copy link

antboiko commented Aug 8, 2016

Hi @vjacquemin-sqli , thanks for reporting. We have already created internal ticket MAGETWO-55900 to fix this issue.

Best,
Anton.

@antboiko antboiko added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Aug 8, 2016
mmansoor-magento pushed a commit that referenced this issue Sep 28, 2016
…5883 #5861

Merge remote-tracking branch 'origin/develop' into MAGETWO-55900
mmansoor-magento pushed a commit that referenced this issue Sep 28, 2016
Fixed issues: 
- MAGETWO-58237: Order status history contains wrong data after creation of a Credit Memo
- MAGETWO-58386: Eliminate dependencies on modules from lib/Magento
- MAGETWO-55120: [GitHub] No category id on the category page #5467
- MAGETWO-55900: [GitHub] Translate messages on password strength #5509 #5883 #5861
- MAGETWO-50412: [GITHUB] Issues with adding groups on attribute set creation page (#3607)
@olysenko
Copy link

Fix for the issue was delivered to develop branch in commit 14028aa
Backports for 2.1 and 2.0 are scheduled and will be delivered later

@Ctucker9233
Copy link

@olysenko any commit references for the backports?

hostep pushed a commit to hostep/magento2 that referenced this issue Sep 2, 2017
…s on password strength magento#5509 magento#5883 magento#5861

(cherry picked from commit f67e598)

Not included validation messages from magento@6ce2b5f (MAGETWO-42994)
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-72250

@magento-team magento-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report labels Sep 2, 2017
mmansoor-magento pushed a commit that referenced this issue Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

8 participants