-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mini cart shows old values when customer session is over #4416
Comments
Same here. I think maybe this has something to do with sessions save? |
Same here |
@Katerina1993 @andidhouse @redboxmarcins Thank you for reporting this issue. Looks like we already have a similar item in our backlog with the internal id |
@ishakhsuvarov |
Fixes magento#4460 Fixes magento#4416 Fixes magento#1461 Fixes magento#4969 Fixes MAGETWO-52593 This method is executed on `controller_action_predispatch`. The outcome of the following controller will be affected by leaving `$this->checkoutSession->setLoadInactive` set `true`. After placing an order the `customer/section/load` page is called from the checkout overview page to update the minicart and messages sections. Because of the `controller_action_predispatch` and the passing of all checks in `\Magento\Persistent\Observer\CheckExpirePersistentQuoteObserver::execute` `setLoadInactive` is left set to true and the expired quote is loaded one more time in the minicart, resulting in expired quote data the browser storage for the success page to display. By the way, I saw this comment: ```php !$observer->getControllerAction() instanceof \Magento\Checkout\Controller\Onepage // persistent session does not expire on onepage checkout page to not spoil customer group id ``` customer/section/load is not a checkout onepage controller, but it most certainly is called in the checkout. So the check in `\Magento\Persistent\Observer\CheckExpirePersistentQuoteObserver::execute` does not fully fill the gap the way the comment implies.
Fixes magento#4460 Fixes magento#4416 Fixes magento#1461 Fixes magento#4969 Fixes MAGETWO-52593
@deep1086 this issue seems to be fixed several month ago. Did you manage to reproduce it on version 2.0.9 or 2.1.1? |
According to contributor guide, tickets without response for two weeks should be closed. |
Fixes magento#4460 Fixes magento#4416 Fixes magento#1461 Fixes magento#4969 Fixes MAGETWO-52593 (cherry picked from commit 9093ce9)
Steps to reproduce
Expected result
Actual result
The text was updated successfully, but these errors were encountered: