-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product Duplication crash #4096
Comments
@urielbeaupre that is a debug log and not an error log. it just shows when cache is being invalidated. Do you have any details in |
On the exception log I have this |
Same issue magento 2.0.4 when I´m tryed duplicate a product. I can´t finish action Save & Duplicate product always display "Please Wait", next I´m recived and message from server: Our automated system has noticed that the disk of server is full. When I´m checked this abnormal behavior I have realized that the images of the product I wanted to duplicate had increased to fill the entire disk space in my case in directory /media/catalog/product/r. |
I am also getting the same sort of issue with 'save and duplicate' a product with magento 2.0.4 It just hangs and eventually times out with a 500 error. I dont get the "Please Wait" message anymore, but i did yesterday when i was trying to duplicate a product. |
|
@salelsol @simonkguest @urielbeaupre do you still get this issue in later versions? |
- Hi, I´ve solved this issue if duplicate a product in an all new product in and all new categorie, then I haven´t any issue when duplicate a product, but for old Magento 1 imported products with yours categories, I can´t duplicate any product because crash server. Lasted version tryed is Magento 2.0.6.
Best Regards
Toni
|
Internal issue MAGETWO-53526 |
For me, the way i have been working around this issue; This has been working for me. I hope this may help I believe that salelsol is correct I have not been able to duplicated imported products either. |
My Products were originally created in Magento 2.0.3... never in a 1.x install I never had a problem with product duplication myself until I upgraded to 2.1.0 recently... now when I Save an Duplicate a new product the behavior is the same as described here in this post. If I should open a new post just holler... I was on the fence as the behavior seems the same as is noted here... the major difference being I never had my products exported from a 1.x site -Open existing Product Nothing in my Apache Error Log for the 500 response either unfortunately Save+Duplicate does appear to Save the Product... but it does not Duplicate currently for most of my current products I tested on a variety of Products... some original Products, some previously Duplicated Products... it "seems" that products I originally created I can still duplicate... but products I have that I once duplicated from another product cannot themselves be duplicated... I haven't exactly kept tracked of which ones were once duplicates... most of products are duplicates as that's often the easiest way to build out a catalog of new/existing products. OK -- so it appears to be related to "Product in Websites" options... if I uncheck all Websites, save the product, I can then Save + Duplicate on a product on couldn't have otherwise... My "old"/originally created products seem to work fine with Save + Duplicate and a Website selected but my "newer"/duplicated products can only Save+Duplicate if I first uncheck all associated Websites |
Eh... further issues with Images on Duplicated Products... after deleting eh original products Base Image I cannot set a new base/thumbnail image... well, I can set it... but it won't appear on the frontend for the Thumbnail or Small image... it only shows up in the actual Product View... Category View pulls in the system default image for the thumb/small display Creating new products works fine |
I don't seem to have any issues duplicating new/post-2.1.0 upgrade products... it's only when I duplicate products I created pre 2.1.0 that I have the various previously mentioned issues I haven't extensively tested duplicating new products from/to a different store/store-view... but basic save+duplicate seems to be fine with newly created products |
Hi there, look like a bug for me too. |
Any news here? Same problem ...v 2.1 |
Fatal error: Uncaught Error: Call to a member function getOrigData() on null in /Applications/MAMP/htdocs/z/app/code/Ess/M2ePro/Observer/StockItem/Save/After.php:54 Stack trace: #0 /Applications/MAMP/htdocs/z/app/code/Ess/M2ePro/Observer/StockItem/Save/After.php(46): Ess\M2ePro\Observer\StockItem\Save\After->processQty() #1 /Applications/MAMP/htdocs/z/app/code/Ess/M2ePro/Observer/AbstractModel.php(66): Ess\M2ePro\Observer\StockItem\Save\After->process() #2 /Applications/MAMP/htdocs/z/vendor/magento/framework/Event/Invoker/InvokerDefault.php(73): Ess\M2ePro\Observer\AbstractModel->execute(Object(Magento\Framework\Event\Observer)) #3 /Applications/MAMP/htdocs/z/vendor/magento/framework/Event/Invoker/InvokerDefault.php(61): Magento\Framework\Event\Invoker\InvokerDefault->_callObserverMethod(Object(Ess\M2ePro\Observer\StockItem\Save\After), Object(Magento\Framework\Event\Observer)) #4 /Applications/MAMP/htdocs/z/vendor/magento/framework/Event/Manager.php(66): Magento\Framework\Event\Invoker\InvokerDefault->dispatch(Array, Obj in /Applications/MAMP/htdocs/z/app/code/Ess/M2ePro/Observer/StockItem/Save/After.php on line 54 |
i use in version 2.1.1 |
Has anyone come up with a fix for this? We're seeing the same thing on products that were migrated to magento 2. After a client attempted to duplicate a pre-migration product, some loop caused it to duplicate the image thousands of times, leaving us filling our entire disk. |
@jwallb40 I have the same issue. M2 2.1.0. Images are keep creating when I try to duplicated migrated products. It only stops once PHP timeout. |
@jwallb40 I am having same issue. When we duplicate any product, it generates almost 4000 images. We have only 13 products in store and we tried to duplicate some of them and suddenly our media folder size increase to 130GB from 80MB. This is super strange and suspecious issue. Anybody found solution for this issue? |
Any news on this? Fixed in 2.1.3? |
We had a similar issue with 2.1.4. I was able to isolate it to the way url rewrites were getting generated in the copying process. The error is a bit misleading it has to do with To fix we just need to force the
you can also see that I've added a counter for the do-while loop so it will break after 20 attempts, this do-while loop is the whats causing the images to be copied over and over, so I figured it would be safer to just cut this off at 20 even if I fixed the It probably should also be investigated why the images are being processed before the save is complete. |
Hey @ryangall7, thanks for your solution! Does this still work for you? If yes: how can I use it without changing core-code? Is there a way to override it? If yes, could you tell me, how you've done it? Thanks in advance! |
Thank you ... setting the url to null worked, at least to copy an imported product (from Magento 1.9) |
Hey @FreederFree, Yes, we added it to a custom module and overwrote the class with dependency injection, if your not familiar here's is a pretty good tutorial: http://inchoo.net/magento-2/overriding-classes-magento-2/ Here is my di.xml
and here is the overriding class NAMESPACE/MODULE_NAME/Model/Product/Copier.php
|
@ryangall7: Thank you for your detailed answer, the tutorial and your code! It helped a lot! Now as I have my module which overrides the Copier class, I get the following error while duplicating a Product:
What could went wrong here? I'm running Magento 2.0.13 by the way |
This is a huge issue! |
I have just made 110GB free by removing all the duplicates... My god this is a mess. |
Almost impossible to fix on 2.0.7 without upgrading it and facing another thousand problems. :( What I did was: create a module with a plugin that overrides \Magento\Catalog\Model\Product\Copier (with surround approach) and simply adds a |
Same issue still occurs on 2.1.7 |
@r-martins Please can you explain in a little more detail and what I need to do. I can confirm that this bug is still in Magento 2.1.7 |
I've built a module to cleanup product, category and swatches media which is not used. |
I have exactly the same issue in Magento 2.1.9 |
This issue seems to be fixed on 2.2.0 branch, see #9466 (comment) for details. Credit for investigation goes to @hostep 👍 |
@orlangur: would be great if a fix could get backported to version 2.1.x though, it's a really serious problem... |
The problem still exists in 2.2.4. We went from 4 GB media to 80 GB media |
Thanks for the update @VirtusB! It looks like they re-added catching that @orlangur: I'm re-opening ticket #9466 if you don't mind, since the issue in 2.2.x was never really solved and was accidentally hidden away and has now re-appeared in 2.2.4 (not tested myself, but the evidence seems to point in that direction). |
@hostep I am also facing same problem with 2.2.4. with duplication space filled by duplicate images. |
I can confirm this has just happed to us in 2.2.4 - migrated product, duplicate - 10,000s of images created till you kill the process |
exception log - site is multi store |
@mattyl: might be best to continue in #9466, that's the issue which has status "Open" an has more detailed information about the problem. Especially this comment: #9466 (comment) |
Magento does not change url path when duplicates product. It causes infinit loop in Copier model when original product has url path.
Fixed issues: - MC-5681: Implement handling of large number of addresses on Onepage Checkout
🙀🤯! |
We currently have magento 2.0.4 installed on Linux server running nginx and php5, we also have it installed on another machine with php7 and this issue occurs in both instalations.
We have a fairly decent sized catalog list (5000) and are on the process of restructuring the catalog. To do this we are duplicating products and this is where the problem starts, when duplicating the product magento just goes on a loop while reloading page, right after the spinning wheel disappears, this doesnt happen in every product but I can't see a common field or setting on the products that it does it on either.
I checked the debug.log while the page is stuch on loop and found the following error:
[2016-04-11 13:39:17] main.DEBUG: cache_invalidate: {"method":"POST","url":"http://test.ch.vpdev.no/adm/catalog/product/save/id/3355/set/14/key/edc2211dbf867a295c96143cf36672b71a02761d3e713d49e75332daa72e966a/active_tab/product-details/back/duplicate/active_tab/product-details/","invalidateInfo":{"tags":["catalog_product_4906"],"mode":"matchingAnyTag"},"is_exception":false} [] [2016-04-11 13:39:17] main.DEBUG: cache_invalidate: {"method":"POST","url":"http://test.ch.vpdev.no/adm/catalog/product/save/id/3355/set/14/key/edc2211dbf867a295c96143cf36672b71a02761d3e713d49e75332daa72e966a/active_tab/product-details/back/duplicate/active_tab/product-details/","invalidateInfo":{"tags":["catalog_product"],"mode":"matchingAnyTag"},"is_exception":false} [] [2016-04-11 13:39:17] main.DEBUG: cache_invalidate: {"method":"POST","url":"http://test.ch.vpdev.no/adm/catalog/product/save/id/3355/set/14/key/edc2211dbf867a295c96143cf36672b71a02761d3e713d49e75332daa72e966a/active_tab/product-details/back/duplicate/active_tab/product-details/","invalidateInfo":{"tags":["catalog_product_4906","catalog_product"],"mode":"matchingAnyTag"},"is_exception":false} []
This error is being printed out roughly 10 times per second, and once it starts the whole website becomes unavailable, we found 2 ways to bring the website back up one is to rewrite the static files (we tried both on dev mode and prod mode) and the other one is to reboot the server. Altough this doesn't really help us as the products still can't be duplicated.
Any insight on this problem will be extremly helpfull.
Best Regards
Joni Silva
The text was updated successfully, but these errors were encountered: