Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public Hash Error #38436

Closed
1 of 5 tasks
apriddy-16 opened this issue Feb 8, 2024 · 13 comments
Closed
1 of 5 tasks

Public Hash Error #38436

apriddy-16 opened this issue Feb 8, 2024 · 13 comments
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.5-p1 Indicates original Magento version for the Issue report.

Comments

@apriddy-16
Copy link

Preconditions and environment

  • Magento version: 2.4.5-p1
  • Anything else that would help a developer reproduce the bug

Steps to reproduce

  1. Go to Sales > Orders
Screenshot 2024-02-08 at 5 36 59 PM 2. Click create new order Screenshot 2024-02-08 at 5 37 29 PM 3. Select an existing client with a saved CC (i.e. AP Anna Priddy) 4. Add a product to the order Screenshot 2024-02-08 at 5 39 32 PM 5. Select any product to add and configure. 6. Select a stored card Screenshot 2024-02-08 at 5 40 55 PM 7. Select a shipping rate 8. Click Submit Order 9. The following error is then shown: Order saving error: Public hash should be defined Screenshot 2024-02-08 at 5 41 41 PM

Expected result

Currently, we have discovered the Public Hash error when customers try to create a new order with a saved credit card, they get this error. Also, we see this error when we try to place an order for an existing customer from the Admin panel. It has to do with the Vault where credit cards are saved.

When the order is placed in the admin and the payment option is selected for a saved CC, we expect the order to process.

Actual result

When the saved payment option is selected, when you hit the 'place order' we expect the order to process.

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Feb 8, 2024

Hi @apriddy-16. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@engcom-November engcom-November added the Reported on 2.4.5-p1 Indicates original Magento version for the Issue report. label Feb 9, 2024
@engcom-Dash engcom-Dash self-assigned this Feb 9, 2024
Copy link

m2-assistant bot commented Feb 9, 2024

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@devchris79
Copy link

I think this has been reported a couple of times:

#32943
#34424

@apriddy-16
Copy link
Author

apriddy-16 commented Feb 9, 2024 via email

@vipin12117
Copy link

Same issue exists in Magento 2.4.6.p3. So looks like this is never checked and fixed.

@engcom-Dash
Copy link
Contributor

@magento give me 2.4-develop instance

Copy link

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

Copy link

@devchris79
Copy link

I think this may be fixed in 2.4.6, #33954 seems to be the same with a workaround and Related commits: fd7e45e

@engcom-Dash
Copy link
Contributor

Hi @apriddy-16

Thanks for reporting and collaboration.

Verified the issue in both 2.4.6-p3 and 2.4.7 beta 2.
In 2.4.6-p3 the issue is reproducible. please refer the below screenshot.

Screenshot 2024-02-12 at 6 53 01 PM

But, in 2.4.7-beta2 the issue is not reproducible. please refer the attached screen recording.

Screen.Recording.2024-02-12.at.6.52.20.PM.mov

Seems like the issue is fixed in latest magento.
However, we are trying to test this issue in 2.4 latest dev instance. will update on the results soon.

Thanks.

@engcom-Dash engcom-Dash added the Issue: needs update Additional information is require, waiting for response label Feb 12, 2024
@engcom-Dash
Copy link
Contributor

Hi @apriddy-16

We have noticed that this issue has not been updated since long time.
Hence we assume that this issue is fixed now, so we are closing it. Please feel to raise a fresh ticket or reopen this ticket if you need more assistance on this.

Thanks

@EugenOrosan
Copy link

What is the fix for the issue? Is there any patch available?

@vipin12117
Copy link

Looks like you are using custom payment method or older magento version. You have to add below line in vault.js

this.$vaultContainer.find('[name="payment[public_hash]"]').val(this.publicHash);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.5-p1 Indicates original Magento version for the Issue report.
Projects
None yet
Development

No branches or pull requests

6 participants