Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong row subtotal on invoice emails #38213

Closed
1 of 5 tasks
fmarangi opened this issue Nov 22, 2023 · 14 comments
Closed
1 of 5 tasks

Wrong row subtotal on invoice emails #38213

fmarangi opened this issue Nov 22, 2023 · 14 comments
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.6 Indicates original Magento version for the Issue report.

Comments

@fmarangi
Copy link

fmarangi commented Nov 22, 2023

Preconditions and environment

  • Magento version 2.4.6 (the bug has been present for at least 4 years)

Steps to reproduce

  1. Add product to cart with qty 2 e.g. Joust Duffle Bag @ $ 34.00
  2. Checkout, any payment method
  3. Place the order
  4. On the backend, Issue an invoice for the order
  5. Only invoice qty 1

Expected result

The row subtotal in the invoice email is $ 34.00

Actual result

The row subtotal in the invoice email is $ 68.00

Additional information

For some reason, the invoice item renderer uses $block->getItemPrice($_item->getOrderItem()) instead of $block->getItemPrice($_item) (compare https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Sales/view/frontend/templates/email/items/invoice/default.phtml with all other item renderer, ie order, credit memo, etc.)

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Nov 22, 2023

Hi @fmarangi. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@hostep
Copy link
Contributor

hostep commented Nov 22, 2023

Going through git's history, it looks like your issue got introduced by #11297, which was to fix #5105
So it sounds like this fix maybe wasn't the best way to solve that issue, maybe there is a better way.

@engcom-Bravo engcom-Bravo self-assigned this Nov 23, 2023
Copy link

m2-assistant bot commented Nov 23, 2023

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.6 Indicates original Magento version for the Issue report. label Nov 23, 2023
@fmarangi
Copy link
Author

@magento give me 2.4-develop instance

Copy link

Hi @fmarangi. Thank you for your request. I'm working on Magento instance for you.

Copy link

@engcom-Bravo
Copy link
Contributor

Hi @fmarangi,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

Steps to reproduce

  • Add product to cart with qty 2 e.g. Joust Duffle Bag @ $ 34.00
  • Checkout, any payment method
  • Place the order
  • On the backend, Issue an invoice for the order
  • Only invoice qty 1

The subtotal in the invoice email is only $34.

Screenshot 2023-11-23 at 11 56 29 AM

Kindly recheck the behaviour on Magento 2.4-develop instance and elaborate steps to reproduce if the issue is still reproducible.

Thanks.

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Nov 23, 2023
@engcom-Bravo
Copy link
Contributor

Hi @fmarangi,

Kindly provide latest update on this comment #38213 (comment) still you are working on this issue if you are able to reproduce the issue please elaborate the steps to reproduce.Please let us know still if you are facing any issue.

Thanks.

@fmarangi
Copy link
Author

fmarangi commented Dec 4, 2023

@magento give me 2.4-develop instance

Copy link

Hi @fmarangi, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@fmarangi
Copy link
Author

fmarangi commented Dec 8, 2023

@magento give me 2.4-develop instance

Copy link

Hi @fmarangi. Thank you for your request. I'm working on Magento instance for you.

Copy link

@engcom-Bravo
Copy link
Contributor

Hi @fmarangi,

We have noticed that this issue has not been updated since long time.
Hence we assume that this issue is fixed now, so we are closing it. Please feel to raise a fresh ticket or reopen this ticket if you need more assistance on this.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.6 Indicates original Magento version for the Issue report.
Projects
None yet
Development

No branches or pull requests

3 participants