Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFTF: StorefrontApplyPromoCodeDuringCheckoutTest is failing in CI process #26612

Closed
lbajsarowicz opened this issue Jan 31, 2020 · 4 comments
Closed

MFTF: StorefrontApplyPromoCodeDuringCheckoutTest is failing in CI process #26612

lbajsarowicz opened this issue Jan 31, 2020 · 4 comments
Assignees
@lbajsarowicz
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@lbajsarowicz
Copy link
Contributor

Summary (*)

image

Issue occurs randomly, when Magento instance is running slower. It's related with the fact, that Assertion does not wait for Loading Mask to disappear.

Examples (*)

Proposed solution

Extend ActionGroup with <waitForLoadingMaskDisappear>
@lbajsarowicz lbajsarowicz added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Jan 31, 2020
@magento-deployment-service
Copy link

Thanks for opening this issue!

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jan 31, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 31, 2020

Hi @lbajsarowicz. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@lbajsarowicz do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

lbajsarowicz added a commit to lbajsarowicz/magento2-contributions that referenced this issue Jan 31, 2020
@lbajsarowicz
magento#26612 Fix failure on Coupon Apply procedure when loading mask…
c13b83f 
… still on page
@lbajsarowicz lbajsarowicz mentioned this issue Jan 31, 2020
Merged
4 tasks
@ghost ghost assigned lbajsarowicz Jan 31, 2020
@lbajsarowicz lbajsarowicz mentioned this issue Jan 31, 2020
Closed
4 tasks
@slavvka slavvka added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Feb 7, 2020
@slavvka
Copy link
Member

slavvka commented Feb 7, 2020

Hi @lbajsarowicz. Thank you for your report.
The issue has been fixed in #26614 by @lbajsarowicz in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

@slavvka slavvka closed this as completed Feb 7, 2020
magento-engcom-team added a commit that referenced this issue Feb 7, 2020
@magento-engcom-team
ENGCOM-6780: #26612 Fix failure on Coupon Apply procedure when loadin…
66404d9 
…g mask still visible #26614

 - Merge Pull Request #26614 from lbajsarowicz/magento2:bugfix/26612-coupon-failure
 - Merged commits:
   1. c13b83f
magento-engcom-team pushed a commit that referenced this issue Feb 7, 2020
@slavvka
ENGCOM-6780: #26612 Fix failure on Coupon Apply procedure when loadin…
74ee21b 
…g mask still visible #26614
@lbajsarowicz
Copy link
Contributor Author

Thanks @slavvka for closing that :-)

This was referenced May 9, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbajsarowicz lbajsarowicz

Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lbajsarowicz @slavvka @magento-engcom-team