Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewing customer shopping cart in admin shows all products in catalog when there is no active quote #26437

Closed
mustdobetter opened this issue Jan 17, 2020 · 24 comments
Assignees
Labels
Component: Admin Component: Customer Component: Quote Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Progress: PR Created Indicates that Pull Request has been created to fix issue Reported on 2.3.3 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@mustdobetter
Copy link
Contributor

Preconditions (*)

  1. Magento 2.3.3

Steps to reproduce (*)

  1. View a customer in the admin for whom there is no active quote.
  2. Click on the 'Shopping Cart' tab.

Expected result (*)

  1. Nothing shows in the grid, as there is no active quote for which to show items.

Actual result (*)

  1. All products added to Magento show, giving the false impression that this is the contents of the customer's basket, whereas actually it's the contents of the catalog.
@m2-assistant
Copy link

m2-assistant bot commented Jan 17, 2020

Hi @mustdobetter. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@mustdobetter do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jan 17, 2020
@krishprakash krishprakash self-assigned this Jan 18, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 18, 2020

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@rav-redchamps rav-redchamps self-assigned this Jan 20, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 20, 2020

Hi @rav-redchamps. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!


@rav-redchamps rav-redchamps added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Admin Component: Customer Component: Quote labels Jan 20, 2020
@rav-redchamps
Copy link
Contributor

@magento give me 2.4-develop instance

@rav-redchamps
Copy link
Contributor

@magento give me 2.4-develop instance

@krishprakash krishprakash self-assigned this Jan 21, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rav-redchamps. Thank you for your request. I'm working on Magento 2.4-develop instance for you

2 similar comments
@magento-engcom-team
Copy link
Contributor

Hi @rav-redchamps. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rav-redchamps. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rav-redchamps, here is your Magento instance.
Admin access: https://i-26437-2-4-develop.instances.magento-community.engineering/admin_ba54
Login: 2c717022 Password: 6b9915b13537
Instance will be terminated in up to 3 hours.

@rav-redchamps
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @rav-redchamps. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rav-redchamps, here is your Magento instance.
Admin access: https://i-26437-2-4-develop.instances.magento-community.engineering/admin_08c7
Login: bde65e13 Password: 0a31daa50f00
Instance will be terminated in up to 3 hours.

@rav-redchamps
Copy link
Contributor

@magento-engcom-team The admin URL throws a 404 page

@rav-redchamps rav-redchamps added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Jan 22, 2020
@krishprakash krishprakash added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Jan 27, 2020
@ghost ghost unassigned krishprakash Jan 27, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 27, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @krishprakash
Thank you for verifying the issue. Based on the provided information internal tickets MC-30803 were created

Issue Available: @krishprakash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@rav-redchamps rav-redchamps removed the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 27, 2020
rav-redchamps added a commit to redchamps/customer-shopping-carts-tab that referenced this issue Jan 28, 2020
@rav-redchamps
Copy link
Contributor

@mustdobetter I have created the pull request #26489 for the fix of this issue. But seems like it is not going to be merged soon. So, I have packed the fix in the form of a Magento 2 extension https://github.com/redchamps/customer-shopping-carts-tab-fix. You may directly use it till the time pull request is processed.

@mustdobetter
Copy link
Contributor Author

Thank you for working on this @rav-redchamps, and for providing a fix.

@slavvka slavvka added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Feb 7, 2020
@msramanujam
Copy link

Any idea when 2.4 will be released? We currently have this issue on our 2.3.4 system and would like to get an idea on how to deploy a patch to fix this issue ASAP. Appreciate your help.

@rav-redchamps
Copy link
Contributor

@msramanujam you might use this https://github.com/redchamps/customer-shopping-carts-tab-fix in the meantime

@msramanujam
Copy link

msramanujam commented Apr 26, 2020 via email

@xeontcs
Copy link

xeontcs commented Jun 2, 2020

I can recreate the same issue.

What is the reason these fixes are not added to 2.3.5-p1?

Always adding fixes to upcoming version without supporting the current version.

No wonder why Shopify takes the lead with eCommerce nowadays.

@redchamps
Copy link

@xeontcs Not sure why magento didn’t added them to 2.3.5. As shared earlier, you might use below till 2.4 release

https://github.com/redchamps/customer-shopping-carts-tab-fix

@xeontcs
Copy link

xeontcs commented Jun 2, 2020

@redchamps Thank you very much! Highly Appreciated for the fix.

It is working for me 100%

I was bit upset as I have seen many fixes "Fixed in 2.4.x ". It is not even released yet.

@hardikason
Copy link

I have also faced same issue. But most easy and quick solution is overriding getQuote() function as below :

protected function getQuote()
{
if (null === $this->quote) {
$customerId = $this->getCustomerId();
$customer = $this->_customerRepository->getById($customerId);
$storeIds = $this->_storeManager->getWebsite($customer->getWebsiteId())->getStoreIds();
try {
$this->quote = $this->quoteFactory->create()->setSharedStoreIds($storeIds)->loadByCustomer($customerId);
} catch (NoSuchEntityException $e) {
$this->quote = $this->quoteFactory->create()->setSharedStoreIds($storeIds);
}
}
return $this->quote;
}

This issue was coming due to customer website is not getting correctly from backend and so the store Id.

Try this out!!!!

@magento-engcom-team magento-engcom-team added the Reported on 2.3.3 Indicates original Magento version for the Issue report. label Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Admin Component: Customer Component: Quote Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Progress: PR Created Indicates that Pull Request has been created to fix issue Reported on 2.3.3 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

No branches or pull requests

9 participants