Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grunt clean does not clean generated folder #25739

Closed
gwharton opened this issue Nov 25, 2019 · 4 comments
Closed

grunt clean does not clean generated folder #25739

gwharton opened this issue Nov 25, 2019 · 4 comments
Assignees
Labels
Component: Developer Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@gwharton
Copy link
Contributor

gwharton commented Nov 25, 2019

Preconditions (*)

  1. Magento 2.3-develop
  2. Copy the default grunt config
  cp grunt-config.json.sample grunt-config.json
  cp Gruntfile.js.sample Gruntfile.js

Steps to reproduce (*)

  1. Enable production mode
  2. php bin/magento setup:upgrade
  3. php bin/magento setup:di:compile
  4. php bin/magento setup:static-content:deploy
  5. grunt clean

Expected result (*)

  1. generated/code should be empty
  2. generated/metadata should be empty

Actual result (*)

  1. They are not empty.
  2. Analysis of grunt config shows it is still trying to clear var/generation/**/*
@m2-assistant
Copy link

m2-assistant bot commented Nov 25, 2019

Hi @gwharton. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@gwharton do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Nov 25, 2019
@andrewbess andrewbess self-assigned this Nov 26, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 26, 2019

Hi @andrewbess. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!


andrewbess pushed a commit to andrewbess/magento2ce that referenced this issue Nov 26, 2019
- added paths to directory "generated/"
- fixed clean options
@Stepa4man Stepa4man added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Nov 27, 2019
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Nov 27, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 27, 2019

@Stepa4man Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@Stepa4man Stepa4man added the Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release label Nov 27, 2019
@VladimirZaets VladimirZaets added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Dec 9, 2019
@VladimirZaets
Copy link
Contributor

Hi @gwharton. Thank you for your report.
The issue has been fixed in #25765 by @andrewbess in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

magento-engcom-team added a commit that referenced this issue Dec 9, 2019
…d folder' #25765

 - Merge Pull Request #25765 from andrewbess/magento2:issue-25739
 - Merged commits:
   1. b9ef877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Developer Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

5 participants