Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticsearch version selections in admin are overly broad #25674

Closed
dobooth opened this issue Nov 20, 2019 · 5 comments
Closed

Elasticsearch version selections in admin are overly broad #25674

dobooth opened this issue Nov 20, 2019 · 5 comments
Assignees
Labels
Component: Elasticsearch Event: cd-cologne19 Fixed in 2.4.x The issue has been fixed in 2.4-develop branch good first issue Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@dobooth
Copy link
Contributor

dobooth commented Nov 20, 2019

Preconditions (*)

  1. 2.2.x
  2. 2.3.x

Steps to reproduce (*)

  1. When choosing Elasticsearch versions in Stores > Settings > Configuration > Catalog > Catalog > Catalog Search

Expected result (*)

  • Elasticsearch
  • Elasticsearch 5.x(not sure)
  • Elasticsearch 6.x

Actual result (*)

  • Elasticsearch
  • Elasticsearch 5+
  • Elasticsearch 6+

Issues:

  1. Elasticsearch 5 is EOL and should probably be removed for PCI.
  2. The wording is overly broad. We say Elasticsearch 6+ but we really support 6.x. We do not yet support 7.
    There is documentation if they want to use an older, out-of-date version.
@m2-assistant
Copy link

m2-assistant bot commented Nov 20, 2019

Hi @dobooth. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@dobooth do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Nov 20, 2019
@engcom-Charlie engcom-Charlie self-assigned this Nov 21, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 21, 2019

Hi @engcom-Charlie. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Nov 21, 2019
@engcom-Charlie engcom-Charlie added good first issue Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 21, 2019
@ghost ghost unassigned engcom-Charlie Nov 21, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Nov 21, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Charlie
Thank you for verifying the issue. Based on the provided information internal tickets MC-29043 were created

Issue Available: @engcom-Charlie, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@mautz-et-tong mautz-et-tong self-assigned this Nov 29, 2019
@m2-assistant
Copy link

m2-assistant bot commented Nov 29, 2019

Hi @mautz-et-tong. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


mautz-et-tong pushed a commit to mautz-et-tong/magento2 that referenced this issue Nov 29, 2019
…overly broad.

This removes the X.0+ notation and replaces it with X.x notation
@VladimirZaets VladimirZaets added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Dec 29, 2019
@VladimirZaets
Copy link
Contributor

Hi @dobooth. Thank you for your report.
The issue has been fixed in #25838 by @mautz-et-tong in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

magento-engcom-team added a commit that referenced this issue Dec 29, 2019
…n are overly … #25838

 - Merge Pull Request #25838 from mautz-et-tong/magento2:fix-for-25674
 - Merged commits:
   1. cf1b084
   2. 37cf56d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Elasticsearch Event: cd-cologne19 Fixed in 2.4.x The issue has been fixed in 2.4-develop branch good first issue Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

5 participants