Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkout Page Cancel button is not working #21327

Closed
speedy008 opened this issue Feb 19, 2019 · 20 comments
Closed

Checkout Page Cancel button is not working #21327

speedy008 opened this issue Feb 19, 2019 · 20 comments
Assignees
@jignesh26
Labels
Area: Design/Frontend Component: Catalog Component: Checkout Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@speedy008
Copy link
Contributor

speedy008 commented Feb 19, 2019 •
edited by krishprakash
Loading

Preconditions (*)

1.Magento 2.3 Develop

Steps to reproduce (*)

  1. Add any virtual product to cart from front -> Proceed to checkout
  2. Click on Cancel Button.

Expected result (*)

1.There should be some action by clicking on cancel button

Actual result (*)

actual result
1.No action is added on cancel button.
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Feb 19, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Feb 19, 2019 •
edited by jignesh26
Loading

Hi @speedy008. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@speedy008 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@jignesh26 jignesh26 self-assigned this Feb 19, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Feb 19, 2019 •
edited by jignesh26
Loading

Hi @jignesh26. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@jignesh26 jignesh26 added Component: Checkout Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Feb 19, 2019
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Feb 19, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @jignesh26
Thank you for verifying the issue! 👍 Your confirmation will help us to acknowledge and process this report.

@jignesh26 jignesh26 self-assigned this Feb 19, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Feb 19, 2019 •
edited by jignesh26
Loading

Hi @jignesh26. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@jignesh26 jignesh26 added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Feb 19, 2019
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Feb 19, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @jignesh26
Thank you for verifying the issue! 👍 Your confirmation will help us to acknowledge and process this report.

@jignesh26 jignesh26 self-assigned this Feb 19, 2019
@krishprakash krishprakash self-assigned this Feb 19, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Feb 19, 2019 •
edited by speedy008
Loading

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@krishprakash
Copy link

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash, here is your Magento instance.
Admin access: https://i-21327-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@jignesh26 jignesh26 added Component: Catalog and removed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Feb 19, 2019
@jignesh26
Copy link

this issue is related to virtual product, when you dont have shipping information at that time cancel button is not working.

@magento magento deleted a comment from magento-engcom-team Feb 19, 2019
@krishprakash krishprakash added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Feb 19, 2019
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Feb 19, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @krishprakash
Thank you for verifying the issue! 👍 Your confirmation will help us to acknowledge and process this report.

@shikhamis11
Copy link
Member

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11, here is your Magento instance.
Admin access: https://i-21327-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@shikhamis11 shikhamis11 added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Feb 19, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 19, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @shikhamis11
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-98322, MAGETWO-98323 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@sunilit42
Copy link
Contributor

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @sunilit42. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sunilit42, here is your Magento instance.
Admin access: https://i-21327-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

Jitheesh added a commit to Jitheesh/magento2 that referenced this issue Feb 20, 2019
@Jitheesh
Checkout Page Cancel button is not working magento#21327
4a598e7 
- hide cancel button if billing address is not available on current quote
@Jitheesh Jitheesh mentioned this issue Feb 20, 2019
Merged
4 tasks
Jitheesh added a commit to Jitheesh/magento2 that referenced this issue Feb 21, 2019
@Jitheesh
Checkout Page Cancel button is not working magento#21327
5372fdc 
- CR fix
@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your report.
The issue has been fixed in #21356 by @Jitheesh in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 4, 2019
magento-engcom-team added a commit that referenced this issue Mar 4, 2019
@magento-engcom-team
ENGCOM-4376: Checkout Page Cancel button is not working #21327 #21356
5394674 
 - Merge Pull Request #21356 from Jitheesh/magento2:feature/checkout-cancel-21327
 - Merged commits:
   1. 4a598e7
   2. 5372fdc
   3. 642a4eb
magento-engcom-team pushed a commit that referenced this issue Mar 4, 2019
@sivaschenko
ENGCOM-4376: Checkout Page Cancel button is not working #21327 #21356
f3b03d5
@mage2pratik mage2pratik mentioned this issue Mar 5, 2019
Merged
4 tasks
mage2pratik pushed a commit to mage2pratik/magento2 that referenced this issue Mar 5, 2019
@Jitheesh @mage2pratik
Checkout Page Cancel button is not working magento#21327 - hide cance…
b169fe3 
…l button if billing address is not available on current quote
mage2pratik pushed a commit to mage2pratik/magento2 that referenced this issue Mar 5, 2019
@Jitheesh @mage2pratik
Checkout Page Cancel button is not working magento#21327 - CR fix
b2d04ca
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Mar 11, 2019
@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your report.
The issue has been fixed in #21569 by @mage2pratik in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

magento-engcom-team added a commit that referenced this issue Mar 11, 2019
@magento-engcom-team
ENGCOM-4436: [Backport] Checkout Page Cancel button is not working #2…
91bec29 
…1327 #21569

 - Merge Pull Request #21569 from mage2pratik/magento2:2.2-develop-PR-port-21356
 - Merged commits:
   1. b169fe3
   2. b2d04ca
   3. b4af131
magento-engcom-team pushed a commit that referenced this issue Mar 11, 2019
@sivaschenko
ENGCOM-4436: [Backport] Checkout Page Cancel button is not working #2…
edc400d 
…1327 #21569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jignesh26 jignesh26

Labels
Area: Design/Frontend Component: Catalog Component: Checkout Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@sunilit42 @jignesh26 @shikhamis11 @magento-engcom-team @speedy008 @krishprakash