Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot reorder from the first try #15059

Closed
TomashKhamlai opened this issue May 8, 2018 · 8 comments
Closed

Cannot reorder from the first try #15059

TomashKhamlai opened this issue May 8, 2018 · 8 comments
Assignees
Labels
Component: Sales Event: mm19in Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line help wanted Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@TomashKhamlai
Copy link
Contributor

Preconditions

  1. Latest Magento 2.3-develop

Steps to reproduce

  1. Create a Virtual Product
  2. Register a Customer Account
  3. Place an Order with the Virtual Product
  4. Create an Invoice
  5. Try to Reorder

Expected result

exp

exp1

Actual result

act1

act

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 8, 2018
@rohit-wagento rohit-wagento self-assigned this May 19, 2018
@engcom-backlog-nickolas engcom-backlog-nickolas added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Sales Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release help wanted labels Jul 13, 2018
@engcom-backlog-nickolas

Hello @TomashKhamlai, thank you for your report.
We've acknowledged the issue and added to our backlog.

@ghost ghost added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jul 25, 2018
@arnoudhgz
Copy link
Contributor

arnoudhgz commented Aug 12, 2018

@TomashKhamlai the re-order part, you did this from the back-end, I assume?

I noticed that after clicking the reorder button the items in the cart are not complete, amount is set, but no price and subtotal....

image

If you do a refresh of the page these values are filled normal and you are able to submit the order.

I can confirm this only is an issue with Virtual Products

@TomashKhamlai
Copy link
Contributor Author

TomashKhamlai commented Aug 14, 2018

@arnoudhgz, yes, I did it from the back-end.
The problem with zero prices is also present in the checkout when Customer adds products to the Cart using Web API.

# Uncomment and modify
# endpoint="http://magento.loc/rest"
# username="admin"
# password="123123q"
# customer_email="your@email.here"

# Get Admin Token
admin_token=$(curl -X POST "$endpoint/V1/integration/admin/token" \
--header "Content-Type: application/json" \
-d '{"username":"'"$username"'","password":"'"$password"'"}') && echo $admin_token && admin_token=$(echo $admin_token | tr -d '"')

#Create 'Category 1' navigation link
curl -X POST "$endpoint/V1/categories" \
-H "Content-Type: application/json" \
-H "Authorization: Bearer $admin_token" \
-d '{"category":{"parent_id":2,"name":"Category 1","is_active":true,"level":2,"path":"1/2/3","available_sort_by":[],"include_in_menu":true,"custom_attributes":[{"attribute_code":"is_anchor","value":"1"},{"attribute_code":"path","value":"1/2/3"},{"attribute_code":"url_key","value":"category-1"},{"attribute_code":"url_path","value":"category-1"}]}}' | json_pp

#Create Simple Product
category_id="3"; productSKU1="Simple Product 1" && curl -X POST "$endpoint/V1/products" \
-H "Content-Type: application/json" \
-H "Authorization: Bearer $admin_token" \
-d '{"product":{"sku":"'"$productSKU1"'","name":"'"$productSKU1"'","attribute_set_id":4,"price":10.99,"status":1,"visibility":4,"type_id":"simple","created_at":"2018-01-01 00:00:01","updated_at":"2018-01-01 00:01:00","weight":1,"extension_attributes":{"category_links":[{"position":0,"category_id":"3"}],"stock_item":{"qty":1000,"is_in_stock":true,"is_qty_decimal":false}}}}' | json_pp

#Create a Customer
curl -X POST $endpoint/V1/customers \
-H "Content-Type: application/json" \
-H "Authorization: Bearer $admin_token" \
-d '{"customer":{"default_billing":"1","default_shipping":"1","email":"'"$customer_email"'","firstname":"Yokoshima","lastname":"Hiteca","store_id":1,"website_id":1,"addresses":[{"id":1,"region":{"region_code":"CA","region":"California","region_id":12},"region_id":12,"country_id":"US","street":["6161 West Centinela Avenue"],"company":"Magento","telephone":"555-55-555-55","postcode":"90230","city":"Culver City","firstname":"Yokoshima","lastname":"Hiteca","default_shipping":true,"default_billing":true}],"disable_auto_group_change":0,"extension_attributes":{"is_subscribed":false}},"password":"SuperPassword1"}' | json_pp

#Get the Customer Token
customer_token=$(curl -X POST "$endpoint/V1/integration/customer/token" \
 -H "Content-Type: application/json" \
 -d '{"username":"yhiteca@gmail.com","password":"SuperPassword1"}') && echo $customer_token && customer_token=$(echo $customer_token | tr -d '"')

#Get your Card Id
cart_id=$(curl -X POST "$endpoint/V1/carts/mine" \
-H "Content-Type: application/json" \
-H "Authorization: Bearer $customer_token") && echo $cart_id && cart_id=$(echo $cart_id | tr -d '"')

#Add the product to the Cart
curl -X POST "$endpoint/V1/carts/mine/items" \
-H "Content-Type: application/json" \
-H "Authorization: Bearer $customer_token" \
-d '{"cartItem":{"sku":"'"$productSKU1"'","qty":1,"quote_id":"'"$cart_id"'"}}'

Login as customer "username":"your@email.here","password":"SuperPassword1" and check it out.

@shikhamis11 shikhamis11 self-assigned this Dec 12, 2018
@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@shikhamis11
Copy link
Member

I am working on this issue at #MM19IN

@shikhamis11
Copy link
Member

@okorshenko I have also worked on this issue and proposed solution in my pull request . it is already assigned to @sivaschenko you can also check

@shikhamis11 shikhamis11 added the Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release label Feb 12, 2019
shikhamis11 pushed a commit to opencommerce/magento2 that referenced this issue Feb 19, 2019
shikhamis11 pushed a commit to opencommerce/magento2 that referenced this issue Feb 19, 2019
@magento-engcom-team
Copy link
Contributor

Hi @TomashKhamlai. Thank you for your report.
The issue has been fixed in #21335 by @shikhamis11 in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Feb 25, 2019
magento-engcom-team added a commit that referenced this issue Feb 25, 2019
 - Merge Pull Request #21335 from opencommerce/magento2:2.3dev15059
 - Merged commits:
   1. 3e83284
magento-engcom-team added a commit that referenced this issue Feb 25, 2019
 - Merge Pull Request #21335 from opencommerce/magento2:2.3dev15059
 - Merged commits:
   1. 3e83284
   2. 124b0e0
@magento-engcom-team
Copy link
Contributor

Hi @TomashKhamlai. Thank you for your report.
The issue has been fixed in #21513 by @shikhamis11 in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

magento-engcom-team added a commit that referenced this issue Mar 5, 2019
…#21513

 - Merge Pull Request #21513 from shikhamis11/magento2:2.2-develop-PR-port-21335
 - Merged commits:
   1. 8493e59
   2. 65e9346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Sales Event: mm19in Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line help wanted Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

6 participants