#518 Refactored shipping selection algo classname

magento · Feb 17, 2018 · 32ffc90 · 32ffc90
1 parent 131fc1c
commit 32ffc90
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/app/code/Magento/InventoryShipping/Model/DefaultShippingAlgorithm.php b/app/code/Magento/InventoryShipping/Model/DefaultShippingAlgorithm.php
@@ -29,9 +29,9 @@
 /**
  * {@inheritdoc}
  *
- * This shipping algorithm just iterates over all the sources one by one in particular order
+ * This shipping algorithm just iterates over all the sources one by one in priority order
  */
-class DefaultShippingAlgorithm implements ShippingAlgorithmInterface
+class PriorityShippingAlgorithm implements ShippingAlgorithmInterface
 {
     /**
      * @var SourceSelectionInterfaceFactory
@@ -163,7 +163,6 @@ public function execute(OrderInterface $order): ShippingAlgorithmResultInterface
             }
         }
 
-
         return $this->shippingAlgorithmResultFactory->create([
             'sourceSelections' => $sourceSelections,
             'isShippable' => $isShippable

diff --git a/app/code/Magento/InventoryShipping/Model/ShippingAlgorithmProvider.php b/app/code/Magento/InventoryShipping/Model/ShippingAlgorithmProvider.php
@@ -33,6 +33,6 @@ public function __construct(
      */
     public function execute(): ShippingAlgorithmInterface
     {
-        return $this->objectManager->get(DefaultShippingAlgorithm::class);
+        return $this->objectManager->get(PriorityShippingAlgorithm::class);
     }
 }
diff --git a/app/code/Magento/InventoryShipping/Test/Integration/DefaultShippingAlgorithmTest.php b/app/code/Magento/InventoryShipping/Test/Integration/DefaultShippingAlgorithmTest.php
@@ -8,14 +8,14 @@
 namespace Magento\InventoryShipping\Test\Integration;
 
 use Magento\InventoryCatalog\Api\DefaultSourceProviderInterface;
-use Magento\InventoryShipping\Model\DefaultShippingAlgorithm;
+use Magento\InventoryShipping\Model\PriorityShippingAlgorithm;
 use Magento\Sales\Api\Data\OrderInterface;
 use Magento\Sales\Api\Data\OrderInterfaceFactory;
 use Magento\Sales\Api\Data\OrderItemInterfaceFactory;
 use Magento\TestFramework\Helper\Bootstrap;
 use PHPUnit\Framework\TestCase;
 
-class DefaultShippingAlgorithmTest extends TestCase
+class PriorityShippingAlgorithmTest extends TestCase
 {
     /**
      * @var DefaultSourceProviderInterface
@@ -33,13 +33,16 @@ class DefaultShippingAlgorithmTest extends TestCase
     private $orderFactory;
 
     /**
-     * @var DefaultShippingAlgorithm
+     * @var PriorityShippingAlgorithm
      */
     private $shippingAlgorithm;
 
+    /**
+     * @return void
+     */
     protected function setUp()
     {
-        $this->shippingAlgorithm = Bootstrap::getObjectManager()->get(DefaultShippingAlgorithm::class);
+        $this->shippingAlgorithm = Bootstrap::getObjectManager()->get(PriorityShippingAlgorithm::class);
         $this->defaultSourceProvider = Bootstrap::getObjectManager()->get(DefaultSourceProviderInterface::class);
         $this->orderFactory = Bootstrap::getObjectManager()->get(OrderInterfaceFactory::class);
         $this->orderItemFactory = Bootstrap::getObjectManager()->get(OrderItemInterfaceFactory::class);