Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Added @deprecated to custom_attributes on CustomerAddress via directi… #932

Conversation

texboy
Copy link
Contributor

@texboy texboy commented Sep 14, 2019

…ve and on CustomerAddressInput via @doc

Description (*)

I've added the required deprecated directive to CustomerAddress and CustomerAddress(via @doc).

Manual testing scenarios (*)

  1. Access graphql using either the chromeiQl or any other graphql IDE.
  2. Open documentation tabs and search for CustomerAddress and under Deprecated fields you shoud able to see the custom_attributes field ant a the reason for the deprecation notice.
  3. Search for CustomerAddressInput under documentation and the custom_attributes will have a deprecated notice on its description

Questions or comments

Since the custom_attributes field was not present on any of the web api tests there was no reason to change any of those files responsible for testing the CustomerGraphql module.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@lenaorobei lenaorobei added the Event: mm19br Meet Magento Brazil 2019 label Sep 14, 2019
@texboy texboy requested a review from pfantini September 16, 2019 11:34
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-5916 has been created to process this Pull Request

magento-engcom-team pushed a commit that referenced this pull request Sep 25, 2019
@magento-engcom-team magento-engcom-team merged commit 4fef8ad into magento:2.3-develop Sep 25, 2019
@ghost
Copy link

ghost commented Sep 25, 2019

Hi @texboy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants