Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

graphQl-812: test Add Variation From Another Configurable Product To Cart #866

Merged
merged 5 commits into from
Sep 25, 2019
Merged

graphQl-812: test Add Variation From Another Configurable Product To Cart #866

merged 5 commits into from
Sep 25, 2019

Conversation

VitaliyBoyko
Copy link
Contributor

Description (*)

Added adding a variation from another configurable product to cart test cases

Fixed Issues (if relevant)

  1. [Test coverage] Add configurable product to cart using variation that belongs to another configurable product #812: [Test coverage] Add configurable product to cart using a variation that belongs to another configurable product

@lenaorobei
Copy link
Contributor

When we are trying to add variation that does not belong to the parent product, exception should be thrown. You can create an issue if it does not work as expected and skip test with reference to this issue. Thanks.

@VitaliyBoyko
Copy link
Contributor Author

VitaliyBoyko commented Aug 29, 2019 •
edited
Loading

Hi @lenaorobei

When we are trying to add variation that does not belong to the parent product, exception should be thrown. You can create an issue if it does not work as expected and skip test with reference to this issue. Thanks.

I believe there are 2 cases:

  1. When we are trying to add variation that does not belong to the parent product and does not belong to common parents super attribute - an exception should be thrown.
  2. When we are trying to add variation that does not belong to the parent product and that belongs to common parents super attribute - an exception should not be thrown.

The 2 test case are covered so far. So I should add the 1 test case, right?

@lenaorobei
Copy link
Contributor

I mean that the case you added testAddVariationFromAnotherConfigurableProductToCart should fail and expect exception, but it does not.

@TomashKhamlai
Copy link
Contributor

I agree with @lenaorobei. The configurable product should be added only when a simple product belongs to configurable. Here in the test, we see that it is possible to use simple_10 and simple_30 with configurable_12345, but only simple_30 is a valid input. For simple_10 we expect an exception.

Skipped tests with correct expectations and reference to the issue is a good idea.

Vitaliy Boyko added 2 commits August 31, 2019 11:57
graphQl-812: Added test case for configurable products with different…
2f7b1d9 
… super attributes
Merge branches '2.3-develop' and 'GraphQl-812-testAddVariationFromAno…
45ec553 
…therConfigurableProductToCart' of github.com:magento/graphql-ce into GraphQl-812-testAddVariationFromAnotherConfigurableProductToCart

# Conflicts:
#	dev/tests/api-functional/testsuite/Magento/GraphQl/ConfigurableProduct/AddConfigurableProductToCartTest.php
lenaorobei
lenaorobei suggested changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please skip this specific case with the reference to https://github.com/magento/magento2 issue.
Thanks.

Vitaliy Boyko added 2 commits September 18, 2019 11:25
Merge branches '2.3-develop' and 'GraphQl-812-testAddVariationFromAno…
689f1f8 
…therConfigurableProductToCart' of github.com:magento/graphql-ce into GraphQl-812-testAddVariationFromAnotherConfigurableProductToCart
graphQl-812: marked testAddVariationFromAnotherConfigurableProductWit…
6a0255b 
…hTheSameSuperAttributeToCart as skipped
@VitaliyBoyko VitaliyBoyko mentioned this pull request Sep 20, 2019
Closed
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-5912 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

magento-engcom-team pushed a commit that referenced this pull request Sep 25, 2019
@lenaorobei
ENGCOM-5912: graphQl-812: test Add Variation From Another Configurabl…
062924b 
…e Product To Cart #866
@magento-engcom-team magento-engcom-team merged commit 6a0255b into 2.3-develop Sep 25, 2019
@ghost
Copy link

ghost commented Sep 25, 2019

Hi @VitaliyBoyko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@lenaorobei lenaorobei deleted the GraphQl-812-testAddVariationFromAnotherConfigurableProductToCart branch October 14, 2019 18:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lenaorobei lenaorobei lenaorobei approved these changes

@paliarush paliarush Awaiting requested review from paliarush

Assignees

@lenaorobei lenaorobei

Labels
Auto-Tests: Covered Award: test coverage Partner: Atwix partners-contribution QA failed Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VitaliyBoyko @lenaorobei @TomashKhamlai @magento-engcom-team