Declare @doc and @resolver directives

[Vinai]

Description (*)

These declarations remove a lot of warnings from the PHPStorm GraphQl plugin while editing schema.graphqls files.

References:

• https://graphql.github.io/graphql-spec/June2018/#sec-Type-System.Directives
• https://www.apollographql.com/docs/graphql-tools/schema-directives/

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[Vinai]

Example screenshots without the declarations:

Example screenshots with the declarations:

[magento-engcom-team]

Hi @lenaorobei, thank you for the review.
ENGCOM-5460 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[Vinai]

@lenaorobei I updated the PR despite your existing approval to add a declaration for the @cache directive, too. Please have another look if you still think it's okay - thank you.

[lenaorobei]

@magento run all tests

[Vinai]

Seems like the builds is still stalled. Do you have an ETA when they will work again?
Will the stalled builds be restarted automatically, or should I take some action?

[lenaorobei]

@Vinai we are experiencing some issues with builds and working on the fix. I'll manually re-request builds run. Thanks for understanding and patience.

[Vinai]

Thank you @lenaorobei

[lenaorobei]

@magento run all tests

[lenaorobei]

@magento run Functional Tests build, WebAPI Tests build

[Vinai]

@lenaorobei The WebAPI Tests build seems to be (still?) hanging, it's been 17 hours.
Could you comment with the magic command again please?

[lenaorobei]

@magento run WebAPI Tests build

[ghost]

Hi @Vinai, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.