Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

#682: [Test coverage] Missed parameters at 'setBillingAddressMutation' #700

Conversation

sergiy-v
Copy link

@sergiy-v sergiy-v commented May 11, 2019

Description (*)

Covered with API-functional tests cases in

setBillingAddressOnCart(input: SetBillingAddressOnCartInput): SetBillingAddressOnCartOutput @resolver(class: "\\Magento\\QuoteGraphQl\\Model\\Resolver\\SetBillingAddressOnCart")

Cases which cover case in \Magento\QuoteGraphQl\Model\Cart\SetBillingAddressOnCart::execute:

if (null === $customerAddressId && null === $addressInput) {
    throw new GraphQlInputException(
        __('The billing address must contain either "customer_address_id" or "address".')
    );
}

and

if ($useForShipping && count($addresses) > 1) {
    throw new GraphQlInputException(
        __('Using the "use_for_shipping" option with multishipping is not possible.')
    );
}

Fixed Issues

  1. [Test coverage] Missed parameters at 'setBillingAddressMutation' #682

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@vpodorozh
Copy link
Contributor

@magento run all tests

…t 'setBillingAddressMutation'

Fix static tests
Copy link
Contributor

@vpodorozh vpodorozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@magento-engcom-team
Copy link
Contributor

Hi @vpodorozh, thank you for the review.
ENGCOM-5209 has been created to process this Pull Request

…tation

- fixed `testSetBillingAddressWithoutRequiredParameters`
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-5209 has been created to process this Pull Request

@naydav naydav merged commit 91500be into magento:2.3-develop Jun 12, 2019
@ghost
Copy link

ghost commented Jun 12, 2019

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants