Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Add Totals to CartItemInterface #664

Merged
merged 2 commits into from
Aug 13, 2019

Conversation

pmclain
Copy link
Contributor

@pmclain pmclain commented May 3, 2019

Description (*)

Fixed Issues (if relevant)

  1. Cart items doesn't contain information about prices #633

Manual testing scenarios (*)

  1. Create empty cart
  2. Add cart items
  3. Query cart and request item totals
{
  cart(cart_id: "{{cartId}}") {
    items {
      prices {
        price {
          value
          currency
        }
        row_total {
          value
          currency
        }
        row_total_including_tax {
          value
          currency
        }
      }
    }
    prices {
      grand_total {
        value
        currency
      }
      subtotal_including_tax {
        value
        currency
      }
      subtotal_excluding_tax {
        value
        currency
      }
      subtotal_with_discount_excluding_tax {
        value
        currency
      }
      applied_taxes {
        label
        amount {
          value
          currency
        }
      }
    }
  }
}

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@TomashKhamlai
Copy link
Contributor

@pmclain, could you please merge mainline to this PR?

@pmclain
Copy link
Contributor Author

pmclain commented May 17, 2019

@TomashKhamlai mainline merged d26dbbc

@lenaorobei
Copy link
Contributor

@magento run all tests

@lenaorobei
Copy link
Contributor

@paliarush please approve schema changes.

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-5576 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ghost
Copy link

ghost commented Aug 13, 2019

Hi @pmclain, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper
Copy link
Contributor

keharper commented Oct 7, 2019

Schema changes documented in 2.3.4 as a result of work done by the internal development team.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants