428 - Test coverage: GetAvailableShippingMethodsTest #472
Conversation
Fix for PHP Fatal error: Uncaught Exception: Exception occurred when running the "\/home\/travis\/build\/magento\/graphql-ce\/dev\/tests\/integration\/testsuite\/Magento\/Sales\/_files\/guest_quote_with_addresses.php" fixture: URL key for specified store already exists. in /home/travis/build/magento/graphql-ce/dev/tests/api-functional/framework/Magento/TestFramework/Annotation/ApiDataFixture.php:114
| @@ -0,0 +1,39 @@ | |||
| <?php | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Merge remote-tracking branch 'origin/2.3-develop' into 428-getAvailableShippingMethodsTest
Fix 1) Magento\GraphQl\Quote\Customer\GetAvailableShippingMethodsTest::testGetAvailableShippingMethods
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array (
- 'amount' => 0
- 'base_amount' => 0
+ 'amount' => 10
+ 'base_amount' => 10
'carrier_code' => 'flatrate'
'carrier_title' => 'Flat Rate'
'error_message' => ''
'method_code' => 'flatrate'
'method_title' => 'Fixed'
- 'price_incl_tax' => 0
- 'price_excl_tax' => 0
+ 'price_incl_tax' => 10
+ 'price_excl_tax' => 10
…leShippingMethodsTest
| shipping_addresses { | ||
| available_shipping_methods { | ||
| amount | ||
| base_amount |
There was a problem hiding this comment.
Please, check scheme
Looks like we don't have these fields in scheme declaration
There was a problem hiding this comment.
Looks like we don't have these fields in scheme declaration
@naydav , could you please check app/code/Magento/QuoteGraphQl/etc/schema.graphqls, lines 197-206.
| @@ -14,7 +14,7 @@ | |||
| $product = $objectManager->create(\Magento\Catalog\Model\Product::class); | |||
| $product->setTypeId('simple') | |||
| ->setAttributeSetId($product->getDefaultAttributeSetId()) | |||
| ->setName('Simple Product') | |||
| ->setName('Simple Product For Guest Quote') | |||
There was a problem hiding this comment.
We could not change current fixtures
It's BIC and could lead to some failures in already created tests
There was a problem hiding this comment.
It's BIC and could lead to some failures in already created tests
Travis has passed this change. But If you recommend to not change current fixtures then I can rollback my changes here.
There was a problem hiding this comment.
1. Rollback fixture changes
1. Fix for "URL key for specified store already exists"
…leShippingMethodsTest # Conflicts: # dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/GetAvailablePaymentMethodsTest.php # dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/GetAvailablePaymentMethodsTest.php
|
Hi @atwixfirster, thank you for your contribution! |
Issue: #428