GraphQl-144: [Checkout] Add grouped product to Cart #369

ldusan84 · 2019-02-13T15:25:38Z

Description (*)

Add grouped product to cart feature:

Added handlers for add to cart in di.xml
Added grouped product handler
Added grouped product graphql schema

Fixed Issues (if relevant)

[Checkout] Add grouped product to Cart #144: Add grouped product to Cart

Manual testing scenarios (*)

Create empty cart

mutation {
  createEmptyCart
}

Get cart id:

{
  "data": {
    "createEmptyCart": "cl5qYfT2q0hSdF5H9cee9JGLMDziVy2b"
  }
}

Add grouped product:

mutation {
  addGroupedProductsToCart(
    input: {
      cart_id: "cl5qYfT2q0hSdF5H9cee9JGLMDziVy2b", 
      cartItems: [
        {
          data: {
            sku: "24-WG085_Group",
            grouped_products: [{
              sku: "24-WG085",
              qty: 1
            }]            
          }          
        }
      ]
    }
  ) {
    cart {
      items {
        id
      }
    }
  }
}

The expected result:

{
  "data": {
    "addGroupedProductsToCart": {
      "cart": {
        "items": [
          {
            "id": "1"
          }
        ]
      }
    }
  }
}

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

TomashKhamlai · 2019-02-15T16:43:17Z

app/code/Magento/QuoteGraphQl/Model/Cart/AddToCartHandlerInterface.php

+{
+    /**
+     * @param CartInterface $cart
+     * @param ContextInterface $context


Maybe?
/**
* @param Quote $cart
* @param array $cartItemData
* @return void
*/
I hope it helps.

@TomashKhamlai yes, good spot. Thanks.

TomashKhamlai · 2019-02-15T16:50:23Z

app/code/Magento/QuoteGraphQl/Model/Cart/AddToCartHandlerInterface.php

+namespace Magento\QuoteGraphQl\Model\Cart;
+
+use Magento\Framework\GraphQl\Exception\GraphQlInputException;
+use Magento\Framework\GraphQl\Query\Resolver\ContextInterface;


Shall we keep it here?
use Magento\Framework\GraphQl\Exception\GraphQlInputException;
use Magento\Framework\GraphQl\Query\Resolver\ContextInterface;

@TomashKhamlai makes sense. Thanks.

TomashKhamlai · 2019-02-21T15:58:36Z

I removed the branch locally before checking this PR again. Please check the
app/code/Magento/QuoteGraphQl/Model/Cart/AddToCartHandlerInterface::execute method, I think the problem is there. If class AddProductsToCart implements AddToCartHandlerInterface then you should use Magento\Quote\Api\Data\CartInterface; as first parameter (where you pass use Magento\Quote\Model\Quote) and PHPDoc comment should also be updated.

Try

php bin/magento setup:di:compile

for more details.

galaoleksandr · 2019-03-25T12:36:39Z

Hello. When trying to run php/bin/magento setup:di:compile got an error: PHP Fatal error: Declaration of Magento\QuoteGraphQl\Model\Cart\AddProductsToCart::execute(Magento\Quote\Model\Quote $cart, array $cartItems): void must be compatible with Magento\QuoteGraphQl\Model\Cart\AddToCartHandlerInterface::execute(Magento\Quote\Api\Data\CartInterface $cart, array $cartItemData): void in /home/mykola/sites/magento/mag23-graphql/app/code/Magento/QuoteGraphQl/Model/Cart/AddProductsToCart.php on line 18

ldusan84 · 2019-03-27T14:41:22Z

@galaoleksandr thanks. It's fixed now.

naydav · 2019-06-14T19:30:07Z

@TomashKhamlai please re-check this issue, we are going to delivery functionality in the scope of the next release (pay attention need to resolve conflicts in scheme file)
Thanks

naydav · 2019-06-21T19:07:12Z

app/code/Magento/QuoteGraphQl/Model/Cart/AddGroupedProductToCart.php

@@ -0,0 +1,156 @@
+<?php


All functionality should be moved to GroupedProductGraphQl

naydav · 2019-06-21T19:09:35Z

app/code/Magento/QuoteGraphQl/Model/Cart/AddGroupedProductToCart.php

+     */
+    private function extractSubProducts(array $cartItemData): array
+    {
+        $subProducts = $cartItemData['data']['grouped_products'];


Looks like we can use array_column native function

naydav · 2019-06-21T19:11:56Z

app/code/Magento/QuoteGraphQl/Model/Cart/AddGroupedProductToCart.php

+            ->addFilter('sku', array_keys($subProducts) , 'in')
+            ->create();
+
+        $products = $this->productRepository->getList($searchCriteria)->getItems();


We can use $procudctCollection->getData() for performance improvement
We don't need whole product object, just SKUs

naydav · 2019-06-21T19:14:51Z

app/code/Magento/QuoteGraphQl/Model/Cart/AddGroupedProductsToCart.php

+/**
+ * Add products to cart
+ */
+class AddGroupedProductsToCart implements AddToCartHandlerInterface


Looks like a duplicate of a simple product handler

naydav · 2019-06-21T19:17:13Z

app/code/Magento/QuoteGraphQl/Model/Cart/AddToCartHandlerResolver.php

+/**
+ * @inheritdoc
+ */
+class AddToCartHandlerResolver


It should be an interface with product type and cart item data (under the hood will list of handlers)

naydav · 2019-06-21T19:17:48Z

app/code/Magento/QuoteGraphQl/Model/Resolver/AddGroupedProductsToCart.php

+     */
+    public function resolve(Field $field, $context, ResolveInfo $info, array $value = null, array $args = null)
+    {
+        $cartHash = $this->arrayManager->get('input/cart_id', $args);


Looks like arrayManager is overhead for this operation

lenaorobei

Hi @ldusan84! Wee need to use schema this schema for the implementation https://github.com/magento/architecture/blob/master/design-documents/graph-ql/coverage/add-items-to-cart/AddGroupedProductToCart.graphqls

ldusan84 · 2019-10-31T15:46:27Z

@lenaorobei @naydav please let me know if you are satisfied with the schema and we'll move on - https://github.com/magento/graphql-ce/blob/1d891c9c77823fefca3635517eac0ac465f91a4e/app/code/Magento/GroupedProductGraphQl/etc/schema.graphqls

Thanks

lenaorobei · 2019-10-31T16:02:12Z

app/code/Magento/GroupedProductGraphQl/etc/schema.graphqls

+
+input AddGroupedProductsToCartInput {
+    cart_id: String!
+    cartItems: [GroupedProductCartItemInput!]!


Suggested change

cartItems: [GroupedProductCartItemInput!]!

cart_items: [GroupedProductCartItemInput!]!

I believe there is typo in proposal. Let's keep snake_case for consistency.

lenaorobei · 2019-10-31T16:03:46Z

app/code/Magento/GroupedProductGraphQl/etc/schema.graphqls

+    cartItems: [GroupedProductCartItemInput!]!
+}
+
+input GroupedProductCartItemInput {


input GroupedProductCartItemInput { data: CartItemInput! }

lenaorobei · 2019-10-31T16:07:25Z

@ldusan84 please see comments. Thanks.

ldusan84 · 2019-10-31T17:08:23Z

@lenaorobei thank you for the comments, can you do another quick check please?

lenaorobei · 2019-10-31T17:13:31Z

app/code/Magento/GroupedProductGraphQl/etc/schema.graphqls

+}
+
+input GroupedProductCartItemInput {
+    data: [CartItemInput!]!


I think it should be data: CartItemInput!. Please have a look at Magento/QuoteGraphQl/etc/schema.graphqls:34 for example.

Yes I see what you mean, but in simple products case we can pick only one sku. For grouped products we can pick multiple with different quantities.

The idea was to add separate groped items cart_items: [GroupedProductCartItemInput!]!. They will be displayed in cart as simple products anyway.

lenaorobei · 2019-10-31T17:14:13Z

app/code/Magento/GroupedProductGraphQl/etc/schema.graphqls

+
+input GroupedProductCartItemInput {
+    data: [CartItemInput!]!
+    parent_sku: String @doc(description: "Grouped product SKU.")


Suggested change

parent_sku: String @doc(description: "Grouped product SKU.")

@lenaorobei not sure about this one. How do we add grouped product without knowing it's sku or id?

The idea was to add as a group of simples, so no parent sku is required. In shopping cart it will be listed as multiple simple products.

I think we need to know which grouped product is being added. Same as with configurable - https://github.com/magento/graphql-ce/blob/2.3-develop/app/code/Magento/ConfigurableProductGraphQl/etc/schema.graphqls#L51

lenaorobei · 2019-12-10T21:11:09Z

Sorry to say that but we need to close this PR.

As per additional investigation and conversation with PO it was decided that adding grouped product to cart scenarios can be covered using addSimpleProductsToCart mutation mutation.

DevDocs will be updated in order to reflect this data.

ghost · 2019-12-10T21:11:12Z

Hi @ldusan84, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

ldusan84 added 4 commits January 26, 2019 17:09

The initial schema

77b6e3e

Added add to cart handlers and resolver

7652094

Work around add to cart handlers

9e8468d

Grouped product add to cart WIP

e000f55

ldusan84 requested review from naydav and removed request for naydav February 13, 2019 16:16

TomashKhamlai reviewed Feb 15, 2019

View reviewed changes

Some fixes

6f24bb4

ldusan84 assigned naydav Feb 18, 2019

TomashKhamlai mentioned this pull request Feb 25, 2019

Make '#369 Feature/add grouped product to cart' up to date and testable again #399

Closed

4 tasks

ldusan84 added 2 commits March 27, 2019 15:10

Changed from concrete class to interface

a8920a5

Changed from concrete class to interface

a8fc1de

galaoleksandr added the QA passed label Mar 28, 2019

naydav changed the title ~~Add grouped product to cart~~ GraphQl-144: [Checkout] Add grouped product to Cart May 2, 2019

naydav suggested changes Jun 21, 2019

View reviewed changes

m2-community-project bot added the Progress: changes requested label Jul 10, 2019

lenaorobei suggested changes Sep 9, 2019

View reviewed changes

m2-community-project bot assigned lenaorobei Sep 9, 2019

lenaorobei added the Progress: needs update label Sep 9, 2019

ldusan84 added 2 commits October 30, 2019 16:46

Merge fix

74f01a8

Grouped product GraphQL schema update

1d891c9

lenaorobei reviewed Oct 31, 2019

View reviewed changes

ldusan84 added 2 commits October 31, 2019 17:41

Grouped product add to cart GraphQL schema changes

5d28747

Grouped product add to cart GraphQL small schema change

35bc982

lenaorobei reviewed Oct 31, 2019

View reviewed changes

lenaorobei closed this Dec 10, 2019

keharper mentioned this pull request Jan 10, 2020

GraphQL: Add grouped product example magento/devdocs#6379

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GraphQl-144: [Checkout] Add grouped product to Cart #369

GraphQl-144: [Checkout] Add grouped product to Cart #369

ldusan84 commented Feb 13, 2019 •

edited

Loading

TomashKhamlai Feb 15, 2019

ldusan84 Feb 18, 2019

TomashKhamlai Feb 15, 2019

ldusan84 Feb 18, 2019

TomashKhamlai commented Feb 21, 2019

galaoleksandr commented Mar 25, 2019

ldusan84 commented Mar 27, 2019

naydav commented Jun 14, 2019 •

edited

Loading

naydav Jun 21, 2019

naydav Jun 21, 2019

naydav Jun 21, 2019

naydav Jun 21, 2019

naydav Jun 21, 2019

naydav Jun 21, 2019

lenaorobei left a comment

ldusan84 commented Oct 31, 2019

lenaorobei Oct 31, 2019

lenaorobei Oct 31, 2019 •

edited

Loading

lenaorobei commented Oct 31, 2019

ldusan84 commented Oct 31, 2019

lenaorobei Oct 31, 2019

ldusan84 Oct 31, 2019

lenaorobei Oct 31, 2019

lenaorobei Oct 31, 2019

ldusan84 Nov 16, 2019

lenaorobei Nov 18, 2019

ldusan84 Nov 20, 2019

lenaorobei commented Dec 10, 2019

ghost commented Dec 10, 2019

	cartItems: [GroupedProductCartItemInput!]!
	cart_items: [GroupedProductCartItemInput!]!

GraphQl-144: [Checkout] Add grouped product to Cart #369

GraphQl-144: [Checkout] Add grouped product to Cart #369

Conversation

ldusan84 commented Feb 13, 2019 • edited Loading

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TomashKhamlai commented Feb 21, 2019

galaoleksandr commented Mar 25, 2019

ldusan84 commented Mar 27, 2019

naydav commented Jun 14, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lenaorobei left a comment

Choose a reason for hiding this comment

ldusan84 commented Oct 31, 2019

Choose a reason for hiding this comment

lenaorobei Oct 31, 2019 • edited Loading

Choose a reason for hiding this comment

lenaorobei commented Oct 31, 2019

ldusan84 commented Oct 31, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lenaorobei commented Dec 10, 2019

ghost commented Dec 10, 2019

ldusan84 commented Feb 13, 2019 •

edited

Loading

naydav commented Jun 14, 2019 •

edited

Loading

lenaorobei Oct 31, 2019 •

edited

Loading