This repository has been archived by the owner on Dec 19, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 154
Added a separate resolver for returning category products count #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paliarush
reviewed
Nov 9, 2018
/** @var Category $category */ | ||
$category = $value['model']; | ||
$productsCollection = $category->getProductCollection(); | ||
$productsCollection->setVisibility($this->catalogProductVisibility->getVisibleInSiteIds()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we should have some test cases for tricky scenarios, like:
- show products out of stock
- configurables with out of stock children
- products available in one store, but not available in the other
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corresponding ticket has been created
#255
paliarush
approved these changes
Nov 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
The
product_count
field of the category query now returns a value from the corresponding field ofcatalog_category_entity
. Using this approach brings additional issues since the value in the database sometimes does not reflect the real products count. Moreover, if we request products of this category, the GraphQL query returns only products that are saleable (visible and in stock). Soproduct_count
value will show the different result if some products of the category are out of stock or not visible.Fixed Issues (if relevant)
Manual testing scenarios (*)
product_count
field should corresponds to the total number of fetched productstotal_count
field should equal the value inproducts_count