This repository has been archived by the owner on Dec 19, 2019. It is now read-only.
GraphQl-45: Product textarea field format #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vitaliyboyko <v.boyko@atwix.com>
Signed-off-by: vitaliyboyko <v.boyko@atwix.com>
VitaliyBoyko
commented
Sep 17, 2018
| */ | ||
| public function create(string $formatIdentifier, $data = []) : FormatInterface | ||
| { | ||
| $formatClassName = 'Magento\CatalogGraphQl\Model\Resolver\Product\ProductTextareaAttribute\\' . ucfirst($formatIdentifier); |
There was a problem hiding this comment.
The temporary solution just to show idea.
I'm about to move class name mapping into di.xml .
added 2 commits
September 22, 2018 10:27
…ormat' of https://github.com/magento/graphql-ce into graphQl-44-product-textarea-field-format Signed-off-by: vitaliyboyko <v.boyko@atwix.com> Conflicts: app/code/Magento/CatalogGraphQl/Model/Resolver/Product/ProductTextareaAttribute.php
Signed-off-by: vitaliyboyko <v.boyko@atwix.com>
added 2 commits
September 26, 2018 15:54
…nto graphQl-44-product-textarea-field-format
Signed-off-by: vitaliyboyko <v.boyko@atwix.com>
|
|
VitaliyBoyko
changed the base branch from
rendered-attributes-product
to
2.3-develop
paliarush
reviewed
Oct 24, 2018
| @@ -63,6 +63,13 @@ | |||
| <argument name="collectionProcessor" xsi:type="object">Magento\Catalog\Model\Api\SearchCriteria\ProductCollectionProcessor</argument> | |||
| </arguments> | |||
| </type> | |||
| <type name="Magento\CatalogGraphQl\Model\Resolver\Product\ProductTextAttribute\FormatList"> | |||
paliarush
reviewed
Oct 24, 2018
| use Magento\Catalog\Helper\Output as OutputHelper; | ||
|
|
||
| /** | ||
| * Resolve rendered content for attributes where HTML content is allowed | ||
| */ | ||
| class ProductHtmlAttribute implements ResolverInterface | ||
| class ProductTextAttribute implements ResolverInterface |
There was a problem hiding this comment.
How about ProductTextAttribute => ProductComplextTextAttribute?
paliarush
approved these changes
Oct 24, 2018
paliarush
approved these changes
Oct 24, 2018
paliarush
reviewed
Oct 25, 2018
| @@ -0,0 +1,38 @@ | |||
| <?php | |||
| /** | |||
| * @author Atwix Team | |||
There was a problem hiding this comment.
Please change the copyright
paliarush
approved these changes
Oct 25, 2018
added 3 commits
November 6, 2018 16:04
…duct-textarea-field-format
…:magento/graphql-ce into graphQl-44-product-textarea-field-format
paliarush
approved these changes
Nov 7, 2018
…duct-textarea-field-format
naydav
approved these changes
Nov 9, 2018
paliarush
approved these changes
Nov 9, 2018
-- Update benchmarks scenarios according to updated GraphQL Schema
-- Update benchmarks scenarios according to updated GraphQL Schema
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PROTOTYPE OF FIELD FORMAT STRATEGY
Fixed Issues (if relevant)