Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

[Test Coverage] 'GetBillingAddress' functionality #480

Closed
naydav opened this issue Mar 15, 2019 · 2 comments
Closed

[Test Coverage] 'GetBillingAddress' functionality #480

naydav opened this issue Mar 15, 2019 · 2 comments
Assignees
@atwixfirster
Labels
Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers test-coverage
Milestone
Release: 2.3.2

Comments

@naydav
Copy link
Contributor

naydav commented Mar 15, 2019 •
edited
Loading

Need to cover GetBillingAddress functionality with API-functional tests.

Query scheme: app/code/Magento/QuoteGraphQl/etc/schema.graphqls

Testcases should be created::

\Magento\GraphQl\Quote\Guest\GetBillingAddressTest
- testGetCartWithBillingAddress
- testGetBillingAddressFromCustomerCart
- testGetBillingAddressIfBillingAddressIsNotSet
- testGetBillingAddressOfNonExistentCart

Example: \Magento\GraphQl\Quote\Guest\GetAvailablePaymentMethodsTest

\Magento\GraphQl\Quote\Customer\GetBillingAddressTest
- testGetCartWithBillingAddress
- testGetBillingAddressFromGuestCart
- testGetBillingAddressFromAnotherCustomerCart
- testGetBillingAddressIfBillingAddressIsNotSet
- testGetBillingAddressOfNonExistentCart

Example: \Magento\GraphQl\Quote\Customer\GetAvailablePaymentMethodsTest

Please, reuse current fixtures instead of creating new.

More examples you could find in
https://github.com/magento/graphql-ce/tree/2.3-develop/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer

https://github.com/magento/graphql-ce/tree/2.3-develop/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest
@naydav naydav added good first issue Good for newcomers test-coverage Contribution Day Tickets is good for start on Contribution Day labels Mar 15, 2019
@naydav naydav added this to the Release: 2.3.2 milestone Mar 15, 2019
@naydav naydav assigned naydav and unassigned naydav Mar 15, 2019
@atwixfirster atwixfirster self-assigned this Mar 16, 2019
atwixfirster added a commit that referenced this issue Mar 16, 2019
@atwixfirster
#480: [Test Coverage] 'GetBillingAddress' functionality
305ccd1
@atwixfirster atwixfirster mentioned this issue Mar 16, 2019
Merged
atwixfirster added a commit that referenced this issue Mar 18, 2019
@atwixfirster
#480: [Test Coverage] 'GetBillingAddress' functionality
091fc8e 
1. Fix PHP Fatal error:  Uncaught Exception: Exception occurred when running the "\/home\/travis\/build\/magento\/graphql-ce\/dev\/tests\/integration\/testsuite\/Magento\/Sales\/_files\/guest_quote_with_addresses.php" fixture:
URL key for specified store already exists. in /home/travis/build/magento/graphql-ce/dev/tests/api-functional/framework/Magento/TestFramework/Annotation/ApiDataFixture.php:114
@atwixfirster
Copy link
Contributor

Pull request: #494

Thank you!

atwixfirster added a commit that referenced this issue Mar 20, 2019
@atwixfirster
#480: [Test Coverage] 'GetBillingAddress' functionality
3259298 
1. Added missed quoteIdMask rollback
atwixfirster added a commit that referenced this issue Mar 29, 2019
@atwixfirster
#480: [Test Coverage] 'GetBillingAddress' functionality
e0ffbb4 
Merge remote-tracking branch 'origin/2.3-develop' into 480-test-coverage-getBillingAddress
atwixfirster added a commit that referenced this issue Mar 29, 2019
@atwixfirster
#480: [Test Coverage] 'GetBillingAddress' functionality
bd91a20
atwixfirster added a commit that referenced this issue Apr 1, 2019
@atwixfirster
#480: [Test Coverage] 'GetBillingAddress' functionality
00cda03
@naydav
Copy link
Contributor Author

naydav commented Apr 2, 2019

#494

@naydav naydav closed this as completed Apr 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@atwixfirster atwixfirster

Labels
Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers test-coverage
Projects
None yet
Milestone
Release: 2.3.2
Development

No branches or pull requests
2 participants
@naydav @atwixfirster