ENGCOM-6064: Remove try-catch construction #1002

magento · Oct 14, 2019 · de81a7f · de81a7f
2 parents ec3db73 + da9006b
commit de81a7f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/app/code/Magento/DownloadableGraphQl/Model/Cart/BuyRequest/DownloadableLinksDataProvider.php b/app/code/Magento/DownloadableGraphQl/Model/Cart/BuyRequest/DownloadableLinksDataProvider.php
@@ -40,12 +40,7 @@ public function execute(array $cartItemData): array
 
         if (isset($cartItemData['data']) && isset($cartItemData['data']['sku'])) {
             $sku = $cartItemData['data']['sku'];
-
-            try {
-                $product = $this->productRepository->get($sku);
-            } catch (NoSuchEntityException $e) {
-                throw new GraphQlNoSuchEntityException(__('Could not find specified product.'));
-            }
+            $product = $this->productRepository->get($sku);
 
             if ($product->getLinksPurchasedSeparately() && isset($cartItemData['downloadable_product_links'])) {
                 $downloadableLinks = $cartItemData['downloadable_product_links'];

diff --git a/...tional/testsuite/Magento/GraphQl/ConfigurableProduct/AddConfigurableProductToCartTest.php b/...tional/testsuite/Magento/GraphQl/ConfigurableProduct/AddConfigurableProductToCartTest.php
@@ -265,7 +265,8 @@ public function testAddNonExistentConfigurableProductVariationToCart()
 
         $this->expectException(\Exception::class);
         $this->expectExceptionMessage(
-            'Could not add the product with SKU configurable to the shopping cart: Could not find specified product.'
+            'Could not add the product with SKU configurable to the shopping cart: The product that was requested ' .
+            'doesn\'t exist. Verify the product and try again.'
         );
 
         $this->graphQlMutation($query);