Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#695] Migrate Settings Failing XSD Validation #696

Closed

Conversation

PivitParkour94
Copy link

Description

Added switch statement to validate config/settings files correctly. Increased the error output to help with debugging.
As this is a CLI tool, I can't see any issues with have more verbose output.

Fixed Issues (if relevant)

  1. Migrate Settings Failing XSD Validation Opensource-to-Opensource #695: Migrate Settings Failing XSD Validation Opensource-to-Opensource

Manual testing scenarios

  1. Install data migration tool <composer require magento/data-migration-tool:2.3.1> on existing, working Magento 2.3.1 installation (running in production deploy mode)
  2. cp ./vendor/magento/data-migration-tool/etc/opensource-to-opensource/settings.xml.dist ./vendor/magento/data-migration-tool/etc/opensource-to-opensource/settings.xml
  3. bin/magento -vvv migrate:settings ./vendor/magento/data-migration-tool/etc/opensource-to-opensource/settings.xml
  4. See settings have migrated instead of getting a vague validation error

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)

…tch statement to validate config/settings files correctly. Increased the error output to help with debugging. As this is a CLI tool, I can't see any issues with have more verbose output.
@magento-cicd2
Copy link

magento-cicd2 commented Jun 20, 2019

CLA assistant check
All committers have signed the CLA.

@PivitParkour94
Copy link
Author

It would be good to get this merged in before the magento/data-migration-tool gets too many additions to avoid an annoying merge conflict

@victor-v-rad were you able to do anything about this?

@victor-v-rad
Copy link
Collaborator

Thank you @PivitParkour94 for this high quality PR! Right now I'm preparing new release and will process your PR right after it. Thank you again.

@victor-v-rad
Copy link
Collaborator

victor-v-rad commented Jun 26, 2019

Hi @PivitParkour94

I have not found in our documentation about using settings.xml as an argument in that command line

bin/magento -vvv migrate:settings ./vendor/magento/data-migration-tool/etc/opensource-to-opensource/settings.xml

it should be your config.xml file. For example

bin/magento -vvv migrate:settings ./vendor/magento/data-migration-tool/etc/opensource-to-opensource/1.9.3.8/config.xml

Maybe you used some unreliable source of information about using of the tool.

@PivitParkour94
Copy link
Author

PivitParkour94 commented Jun 27, 2019

Specify the new name of the settings file for mapping. To do that, change the <settings_map_file> tag in the path/to/config.xml file.

Ah, well, that makes sense. I missed the definition of the settings_map_file
What a shame, should've read the manual.

Thanks for your time. Sorry this isn't actually an issue. I'll close it up

@ghost
Copy link

ghost commented Jun 27, 2019

Hi @PivitParkour94, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@victor-v-rad
Copy link
Collaborator

victor-v-rad commented Jun 27, 2019

@PivitParkour94 Yeah, at first glance using settings.xml in migrate:settings command seems quite reasonable. I really appreciate your time and willing to make a contribution anyway. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants