Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solves issue 574 #624

Merged
merged 1 commit into from
Dec 24, 2018
Merged

Conversation

wilfriedwolf
Copy link
Contributor

Description

this fix treats the case when an attribute (such as price) already contains an "apply_to" value.
is MAGETWO-94160

Fixed Issues (if relevant)

  1. magento/data-migration-tool# 574: After migration, Grouped products want a price?

Manual testing scenarios

I used sample data (Magento 1.9.4.0) and migrated it to Magento 2.2.7. The scenario should hold for all versions.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)

this fix treats the case when an attribute (such as price) already contains an "apply_to" value.
is MAGETWO-94160
@victor-v-rad
Copy link
Collaborator

Hi @wilfriedwolf

Thank you for the contribution. I will test it as soon as be able to.

@victor-v-rad victor-v-rad merged commit 99fa75e into magento:2.3-develop Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants