Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only a dot (.) at the end of requested path? #481

Closed
diazwatson opened this issue Mar 15, 2018 · 3 comments
Closed

Only a dot (.) at the end of requested path? #481

diazwatson opened this issue Mar 15, 2018 · 3 comments

Comments

@diazwatson
Copy link
Contributor

diazwatson commented Mar 15, 2018

I am using the tool to migrate data from 1.14.2.3 to 2.2.3
After data step is finished I noticed that all requested paths in the url rewrite table end with only a dot (.)

Source

Configuration

_mysql_5_6_38-83_0__localhost_pramworld_src_core_config_data

Sample Urls

brand/icandy/icandy-strawberr

Destination

Sample Urls

brand/icandy/icandy-strawberr.

Has any body seen this before?

@diazwatson diazwatson changed the title URL_REWRITE: Dot (.) at the end of requested path? Only a dot (.) at the end of requested path? Mar 15, 2018
@victor-v-rad
Copy link
Collaborator

Hi @diazwatson

Thank you for posting this issue. Internal ticket to fix this bug is MAGETWO-89312
As a hot fix you can try to change the line
$suffix = $this->ensureSuffixBeginsWithDot($suffix);
in src/Migration/Step/UrlRewrite/Model/Suffix.php
with
$suffix = ($suffix) ? $this->ensureSuffixBeginsWithDot($suffix) : $suffix;

@diazwatson
Copy link
Contributor Author

Thanks for your reply @victor-v-rad
There is a PR with the changes in case you guys want to integrate it into the repo.

@victor-v-rad
Copy link
Collaborator

Thank you @diazwatson

victor-v-rad added a commit to magento-panda/data-migration-tool that referenced this issue Mar 20, 2018
victor-v-rad added a commit to magento-panda/data-migration-tool that referenced this issue Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants