Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version11410to2000 - temporaryTable #400

Closed
csdougliss opened this issue Oct 26, 2017 · 2 comments
Closed

Version11410to2000 - temporaryTable #400

csdougliss opened this issue Oct 26, 2017 · 2 comments
Labels
acknowledged bug

Comments

@csdougliss
Copy link

csdougliss commented Oct 26, 2017 •
edited
Loading

Hi,

My class extends Version11410to2000, which used the variable tableName which was previously a protected variable. The latest data migration tool changes this to a private variable called temporaryTable.

Could you change this back to a protected variable so my class extend works?

data-migration-tool/src/Migration/Step/UrlRewrite/Version11410to2000.php

Line 24 in 715cef2

private $temporaryTable;

thanks
victor-v-rad added a commit to magento-panda/data-migration-tool that referenced this issue Oct 27, 2017
@victor-v-rad
MAGETWO-82867: [GigHub] Return $temporaryTable to protected visibility …
68ee245 
…magento#400
@victor-v-rad
Copy link
Collaborator

Hi,
Internal ticket MAGETWO-82867. Will be published in the next release

@victor-v-rad victor-v-rad mentioned this issue Nov 9, 2017
Merged
1 task
@csdougliss
Copy link
Author

@victor-v-rad this is now fixed, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acknowledged bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@victor-v-rad @csdougliss