-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(work-around) Exclude text file 'text!js-translation.json' from bundling #51
Conversation
Thanks @tdgroot! This looks great. Would you be willing to add a test to cover this? We can add one in test('js-translation.json not included in computed dep list', () => {
const graph = {
a: ['b'],
b: ['js-translation.json']
};
const entries = ['a'];
expect(computeDepsForBundle(graph, entries)).toEqual(['a', 'b']);
}); |
src/ignoredTextFiles.ts
Outdated
@@ -0,0 +1,8 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on changing this file to something like knownIgnores
or excludedFiles
? We don't discriminate text vs other resource type in computeDepsForBundle
, so we can probably just make use of this file for any future Magento-specific ignores we have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I renamed the file!
Done! |
Thank you for your review! 👍 I added the requested changes. |
Thanks @tdgroot! Appreciate the contribution 😃 |
This fixes #47.
Now, I know that this is not the most thorough solution, but this gets my build going again. Feel free to give feedback/merge/decline!