Skip to content
This repository has been archived by the owner on Apr 29, 2019. It is now read-only.

Add missed $searchCriteriaSearch property #147

Closed
wants to merge 1 commit into from
Closed

Add missed $searchCriteriaSearch property #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...de/Magento/CatalogImportExport/Test/Unit/Model/Import/Product/Validator/TierPriceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ class TierPriceTest extends \PHPUnit\Framework\TestCase
/** @var \Magento\Customer\Api\GroupRepositoryInterface|\PHPUnit_Framework_MockObject_MockObject */
protected $groupRepositoryInterface;

/** @var \Magento\Framework\Api\SearchCriteria|\PHPUnit_Framework_MockObject_MockObject */
protected $searchCriteriaSearch;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think looking at it's usage we do not need this as a call variable but could make it local to the method only. Would you be up for making this change and then validating the phpstan and phpunit test again?

Copy link
Author

@thicolares thicolares Nov 1, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Besides $searchCriteriaSearch, I believe I should do the same for $objectManagerHelper and $searchCriteriaBuilder -- both are also only local and not instantiated via dependency injection.


/** @var \Magento\Framework\Api\SearchCriteriaBuilder|\PHPUnit_Framework_MockObject_MockObject */
protected $searchCriteriaBuilder;

Expand Down