This repository has been archived by the owner on Apr 29, 2019. It is now read-only.
magento-engcom/import-export-improvements#103 Fail product import validation when multiselect columns contain duplicate values #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduced a validation failure with message on product import attribute validation of multiselect columns that contain the same value multiple times.
Without this, in 2.2.2 there were reportedly errors on the indexing run. On 2.3, the indexer errors could not be reproduced, but the values are still saved to catalog_product_entity_varchar multiple times.
@dmanners and I agreed that a validation failure in such a case would be appropriate, forcing the user to supply us with clean data.
Fixed Issues
Manual testing scenarios
Contribution checklist