Skip to content

Commit

Permalink
Fix ServingRuntime kubebuilder annotations (kubeflow#1974)
Browse files Browse the repository at this point in the history
This adjusts the printcolumn annotations to use the correct
key.

Signed-off-by: Paul Van Eck <pvaneck@us.ibm.com>
  • Loading branch information
pvaneck authored Jan 5, 2022
1 parent 172933a commit b1484f5
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion config/crd/serving.kserve.io_clusterservingruntimes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ spec:
- jsonPath: .spec.disabled
name: Disabled
type: boolean
- jsonPath: .spec.supportedModelTypes[*].name
- jsonPath: .spec.supportedModelFormats[*].name
name: ModelType
type: string
- jsonPath: .spec.containers[*].name
Expand Down
2 changes: 1 addition & 1 deletion config/crd/serving.kserve.io_servingruntimes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ spec:
- jsonPath: .spec.disabled
name: Disabled
type: boolean
- jsonPath: .spec.supportedModelTypes[*].name
- jsonPath: .spec.supportedModelFormats[*].name
name: ModelType
type: string
- jsonPath: .spec.containers[*].name
Expand Down
4 changes: 2 additions & 2 deletions pkg/apis/serving/v1alpha1/servingruntime_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ type BuiltInAdapter struct {
// +k8s:openapi-gen=true
// +kubebuilder:object:root=true
// +kubebuilder:printcolumn:name="Disabled",type="boolean",JSONPath=".spec.disabled"
// +kubebuilder:printcolumn:name="ModelType",type="string",JSONPath=".spec.supportedModelTypes[*].name"
// +kubebuilder:printcolumn:name="ModelType",type="string",JSONPath=".spec.supportedModelFormats[*].name"
// +kubebuilder:printcolumn:name="Containers",type="string",JSONPath=".spec.containers[*].name"
// +kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp"
type ServingRuntime struct {
Expand All @@ -192,7 +192,7 @@ type ServingRuntimeList struct {
// +kubebuilder:object:root=true
// +kubebuilder:resource:scope="Cluster"
// +kubebuilder:printcolumn:name="Disabled",type="boolean",JSONPath=".spec.disabled"
// +kubebuilder:printcolumn:name="ModelType",type="string",JSONPath=".spec.supportedModelTypes[*].name"
// +kubebuilder:printcolumn:name="ModelType",type="string",JSONPath=".spec.supportedModelFormats[*].name"
// +kubebuilder:printcolumn:name="Containers",type="string",JSONPath=".spec.containers[*].name"
// +kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp"
type ClusterServingRuntime struct {
Expand Down
4 changes: 2 additions & 2 deletions test/crds/serving.kserve.io_inferenceservices.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ spec:
- jsonPath: .spec.disabled
name: Disabled
type: boolean
- jsonPath: .spec.supportedModelTypes[*].name
- jsonPath: .spec.supportedModelFormats[*].name
name: ModelType
type: string
- jsonPath: .spec.containers[*].name
Expand Down Expand Up @@ -13606,7 +13606,7 @@ spec:
- jsonPath: .spec.disabled
name: Disabled
type: boolean
- jsonPath: .spec.supportedModelTypes[*].name
- jsonPath: .spec.supportedModelFormats[*].name
name: ModelType
type: string
- jsonPath: .spec.containers[*].name
Expand Down

0 comments on commit b1484f5

Please sign in to comment.