Skip to content

Commit

Permalink
Introduce Storage container CRD (kubeflow#3060)
Browse files Browse the repository at this point in the history
* Storage container CRD

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Add CRD to helm

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Add default CR

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Fix default storage container cr

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Update kserve-manager-role in helm charts

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Update crd format, modify controller code and tests

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Update helm charts

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* fix cluster role

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Remove name from CRD

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Update CRD in helm

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Error handling

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Fix kubebuilder rbac annotation

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Add comments

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Fix test

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Update comments

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

---------

Signed-off-by: Jin Dong <jdong183@bloomberg.net>
  • Loading branch information
greenmoon55 authored Aug 23, 2023
1 parent 5a724ba commit 4c1c025
Show file tree
Hide file tree
Showing 17 changed files with 2,652 additions and 5 deletions.

Large diffs are not rendered by default.

12 changes: 12 additions & 0 deletions charts/kserve-resources/templates/clusterrole.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,18 @@ rules:
- patch
- update
- watch
- apiGroups:
- serving.kserve.io
resources:
- clusterstoragecontainers
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- serving.kserve.io
resources:
Expand Down
23 changes: 23 additions & 0 deletions charts/kserve-resources/templates/clusterstoragecontainer.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
apiVersion: "serving.kserve.io/v1alpha1"
kind: ClusterStorageContainer
metadata:
name: default
spec:
container:
name: storage-initializer
image: kserve/storage-initializer:latest
resources:
requests:
memory: 100Mi
cpu: 100m
limits:
memory: 1Gi
cpu: "1"
supportedUriFormats:
- prefix: gs://
- prefix: s3://
- prefix: hdfs://
- prefix: webhdfs://
- regex: "https://(.+?).blob.core.windows.net/(.+)"
- regex: "https://(.+?).file.core.windows.net/(.+)"
- regex: "https?://(.+)/(.+)"
1 change: 1 addition & 0 deletions config/crd/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ resources:
- serving.kserve.io_clusterservingruntimes.yaml
- serving.kserve.io_servingruntimes.yaml
- serving.kserve.io_inferencegraphs.yaml
- serving.kserve.io_clusterstoragecontainers.yaml

patches:
# Fix for https://github.com/kubernetes/kubernetes/issues/91395
Expand Down
Loading

0 comments on commit 4c1c025

Please sign in to comment.