Skip to content

Commit

Permalink
update custom/grpc-service sample (kubeflow#921)
Browse files Browse the repository at this point in the history
upate readme.md
  • Loading branch information
Iamlovingit authored Jul 5, 2020
1 parent 7449e37 commit 2a122bd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
9 changes: 5 additions & 4 deletions docs/samples/custom/grpc-server/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ spec:
predictor:
custom:
container:
name: grpc
image: docker.io/{username}/helloworld-grpc:latest
ports:
- name: h2c
Expand All @@ -51,14 +52,14 @@ spec:
**Get the inference service address:**

```
kubectl get ksvc grpc-service-predictor-default
kubectl get inferenceservice grpc-service
```
**Expect output**
```
NAME URL READY REASON
grpc-service-predictor-default http://grpc-service-predictor-default.default.1.2.3.4.xip.io True
NAME URL READY DEFAULT TRAFFIC CANARY TRAFFIC AGE
grpc-service http://grpc-service.default.1.2.3.4.xip.io True 100 4m30s
```
**How to setup the magic DNS**
Expand All @@ -78,7 +79,7 @@ Replace `{username}` with your Docker Hub user name and run the command:
```shell
docker run --rm {username}/helloworld-grpc \
/client \
-server_addr="grpc-service-predictor-default.default.1.2.3.4.xip.io:80" \
-server_addr="grpc-service.default.1.2.3.4.xip.io:80" \
-insecure
```

Expand Down
1 change: 1 addition & 0 deletions docs/samples/custom/grpc-server/grpc-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ spec:
predictor:
custom:
container:
name: grpc
image: docker.io/iamlovingit/helloworld-grpc:latest
ports:
- name: h2c
Expand Down

0 comments on commit 2a122bd

Please sign in to comment.