Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added individual positions based on time #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krisha
Copy link

@krisha krisha commented Jan 22, 2020

No description provided.

@madmartin
Copy link
Owner

Hello @krisha,

good idea, I assume a lot of work, but one commit for such a huge change is way to little to merge.

Can you split it into "one commit per logical change" please?

@krisha
Copy link
Author

krisha commented Apr 5, 2020

Thank you for your reply.

Actually I think it is just one logical change. The only thing I can imagine is splitting it to 'logic', 'webserver' and 'webserver help' commits, but not sure if that makes sense.

If I split it further it will not build and/or might not work as expected on the single commits.

If I misunderstood, let me know and if possible please also attach an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants