Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old c89 compatibility fix for minizip #695

Closed
wants to merge 14 commits into from

Conversation

gvollant
Copy link
Contributor

fix #668

madler and others added 14 commits March 27, 2022 18:07
The previous releases of zlib were not sensitive to incorrect CRC
inputs with bits set above the low 32. This commit restores that
behavior, so that applications with such bugs will continue to
operate as before.
If the extra field was larger than the space the user provided with
inflateGetHeader(), and if multiple calls of inflate() delivered
the extra header data, then there could be a buffer overflow of the
provided space. This commit assures that provided space is not
exceeded.
The recent commit to fix a gzip header extra field processing bug
introduced the new bug fixed here.
@tbeu
Copy link
Contributor

tbeu commented Sep 5, 2022

Duplicate of #624.

@madler
Copy link
Owner

madler commented Oct 7, 2022

Applied.

@madler madler closed this Oct 7, 2022
@gvollant gvollant deleted the old_C89_compatibility_fix branch October 15, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ioapi.c file in minizip is incompatible with the C89 standard.