Fix MSVC vc14 ReleaseWithoutAsm build #639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MASM optimizations are removed in 1.2.12, but MSVC project files were still refering to masm dir/files, making it impossible to build on MSVC. This commit fix ReleaseWithoutAsm configuration on vc14 vcxproj file. Debug, Release configs are not yet removed since it requires major rewrite of vcxproj file.
|
This needs to be applied to all other VS projects, too. |
|
Build ReleaseWithoutAsm|Win32 failed |
Closed
|
See d0704a8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MASM optimization was removed in v1.2.12 release.
As described in #631, it caused existing MSVC project files under
contrib/vstudioto break.This PR fixes
ReleaseWithoutAsmconfiguration on vc14zlibvc.vcxprojfile.Note1:
DebugandReleaseconfigs are still broken, but clearing them requires a major rewrite. In the meantime, use theReleaseWithoutAsmconfig.Note2: Windows ARM64 binary is buildable by creating a profile based on
ReleaseWithoutAsm|x64.