Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in inflate.c #274

Closed
umokk opened this issue Jul 7, 2017 · 3 comments
Closed

Bug in inflate.c #274

umokk opened this issue Jul 7, 2017 · 3 comments

Comments

@umokk
Copy link

umokk commented Jul 7, 2017

Zlib 1.2.11 supposedly has a bug in inflate.c.
How to reproduce:

  1. Build zlib with asm enabled for x86 (Visual Studio 2017).
  2. Build test\example.c.
  3. Run.
    You'll get access violation in contrib\masmx86\inffas32.asm, line 669: mov eax, [ebx+eax*4]

x64 works fine.
1.2.8 worked fine for both x86 and x64.
@rhuijben
Copy link

rhuijben commented Jul 7, 2017

See also issue #41. I would recommend never enabling the ASM optimizations until this issue is fixed.

@rhuijben rhuijben mentioned this issue Jul 7, 2017
Closed
@umokk
Copy link
Author

umokk commented Jul 9, 2017

And what about inffasx64.asm and gvmat64.asm (x64 asm files)? Are they ok or they're buggy too?

@madler
Copy link
Owner

madler commented Oct 13, 2017

The assembler code is in contrib and not part of the supported zlib. Since that code seems to be causing problems, it will be removed from the distribution.

@madler madler closed this as completed Oct 13, 2017
perdrix52 added a commit to deepskystacker/DSS that referenced this issue Apr 24, 2018
@perdrix52
Use Zlib Static Libraries without Assembler code. Refer to madler/zli…
cc44496 
…b#274

This was causing access violations in the x86 builds of DSS.

The debug builds never used assembler code.
@ied206 ied206 mentioned this issue Apr 12, 2022
Closed
BlazesRus added a commit to BlazesRus/zlib that referenced this issue Jun 4, 2022
@BlazesRus
Turning off Asm option by default in case madler#274 is still issue w…
114a033 
…hen code is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@madler @rhuijben @umokk